Code Monkey home page Code Monkey logo

Comments (4)

dashed avatar dashed commented on June 14, 2024

This isn't easy to do well; and I learned this the hard way via jade-lang.

Also, this would be premature optimization, as minification process would just mostly remove trivial white-space.

from html-loader.

fernandoacorreia avatar fernandoacorreia commented on June 14, 2024

@dashed Thanks for reviewing.

Could you please elaborate what minification process do you use that removes whitespace from within string constants?

The minifier I'm using (usemin) doesn't modify string constants such as this one, which is created by requiring a HTML template file:

module.exports = "<!-- Service order list item template. -->\n<li>\n  <a href=\"#serviceOrderDetails?id={id}\">\n    <h3>#{number} {customer}</h3>\n    <p>{description}</p>\n    <span class=\"ui-li-count\">{status}</span>\n    <p class=\"ui-li-aside\"><strong>{time}</strong></p>\n  </a>\n</li>\n"

Or are you referring to minification that should occur before the required file is bundled?

from html-loader.

dashed avatar dashed commented on June 14, 2024

I don't think usemin is a minifier. usemin would just replace references of files with their minified counter-parts.

For example: references to something.css would be replaced with something.min.css. The existence of something.min.css is handled by another task.


I would recommend not to remove the whitespace as the savings is, most of the time, negligible. And this may hurt formatting.

If you really want to do this, you may check this out: https://github.com/kangax/html-minifier

from html-loader.

fernandoacorreia avatar fernandoacorreia commented on June 14, 2024

@dashed Thanks for your correction. It turns out I'm actually using html-minifier. I'm still interested in having my templates minimized in production. One of the reasons is that they'll be applied several times, on a mobile device, and I see no point in wasting cycles (and battery). Also, I don't want to ship code comments to production.

@sokra Thank you for your code commit. I'll test it.

from html-loader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.