Code Monkey home page Code Monkey logo

Comments (5)

watjurk avatar watjurk commented on August 31, 2024

Hi, recently I've been working a lot with this plugin, and I think I have a solution to this issue but I don't know what are your thoughts on this:

change the module retrieving hook:

compilation.hooks.succeedModule.tap(ESLINT_PLUGIN, processModule);

to:

compilation.hooks.finishModules.tap(ESLINT_PLUGIN, processModules) // function processModules needs to be written

now we retrieve all modules at once, so we can filter them after striping resource query:

function processModules(modules) {
  const resources = modules.map((module) => module.resource.split('?')[0]);
  const resourcesUnique = new Set(resources);
  // TODO: process resourcesUnique
}

now when we are sure that every file if processed only once, we can remove all logic involving resultStorage:

const resultStorage = new WeakMap();

function getResultStorage({ compiler }) {
let storage = resultStorage.get(compiler);
if (!storage) {
resultStorage.set(compiler, (storage = {}));
}
return storage;
}

as far as I understand it was created to filter the results:

for (const result of results) {
crossRunResultStorage[result.filePath] = result;
}
results = Object.values(crossRunResultStorage);

from eslint-webpack-plugin.

alexander-akait avatar alexander-akait commented on August 31, 2024

Don't think we should keep cache for compiler, we have modules, i.e. we can use module as key for weak map

from eslint-webpack-plugin.

watjurk avatar watjurk commented on August 31, 2024

I'm not sure if I understand your point. My idea is to completely remove everything involving our cache (called resultStorage)

from eslint-webpack-plugin.

alexander-akait avatar alexander-akait commented on August 31, 2024

@watjurk When you change one file, it will invalidate whole cache, it is not effective

from eslint-webpack-plugin.

watjurk avatar watjurk commented on August 31, 2024

This plugin as it is right now (in my understanding) doesn't use resultStorage as cache, every time lint (in src/linter.js) is called every file from files is linted again no matters what crossRunResultStorage says

from eslint-webpack-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.