Code Monkey home page Code Monkey logo

Comments (9)

jrnail23 avatar jrnail23 commented on August 31, 2024 4

@ricardogobbosouza, it's the globs. Since the my files option didn't contain glob paths, processModule isn't matching them. That's a breaking change, I think.
Also, in the previous version, running watch with lintDirtyModulesOnly would only run the linter after files were changed. Now it lints the whole graph on the first run -- that makes the initial build MUCH slower, killing much of lintDirtyModulesOnly's value.

from eslint-webpack-plugin.

ricardogobbosouza avatar ricardogobbosouza commented on August 31, 2024 2

Hi @jrnail23
Resolved v2.3.0
If the problem persists, reopen this

from eslint-webpack-plugin.

jrnail23 avatar jrnail23 commented on August 31, 2024 1

@ricardogobbosouza, I just tried v2.2.0, and it doesn't seem to be raising eslint warnings at all when using lintDirtyModulesOnly in watch mode.

I'm using the same config as above:

new ESLintWebpackPlugin({
  files: ['src/client', 'src/shared'],
  extensions: ['js', 'jsx'],
  cache: true,
  lintDirtyModulesOnly: true,
}),

from eslint-webpack-plugin.

undermuz avatar undermuz commented on August 31, 2024

I have same problem on windows with [email protected]

from eslint-webpack-plugin.

ricardogobbosouza avatar ricardogobbosouza commented on August 31, 2024

Hi @jrnail23
Try v2.2.0

from eslint-webpack-plugin.

jrnail23 avatar jrnail23 commented on August 31, 2024

@ricardogobbosouza trying it now. Thanks for the heads up. I'll let you know what happens.

from eslint-webpack-plugin.

jrnail23 avatar jrnail23 commented on August 31, 2024

@ricardogobbosouza, to be clear, that's a bad thing. It's not outputting eslint errors or warnings when I add them to a file in watch mode.

from eslint-webpack-plugin.

ricardogobbosouza avatar ricardogobbosouza commented on August 31, 2024

@jrnail23
If you can share the repository it would be of great help

from eslint-webpack-plugin.

ricardogobbosouza avatar ricardogobbosouza commented on August 31, 2024

@jrnail23 Remembering that only files imported on the graph will be linted, at least it is the expected behavior.

Ex:
src/index.js

import('./lint')

src/lint.js

// this file will linted
const foo = 'bar'

src/no-lint.js

// this file will not linted, why not being used

webpack.config.js

const ESLintPlugin = require('eslint-webpack-plugin');

module.exports = {
  plugins: [new ESLintPlugin({lintDirtyModulesOnly: true})],
};

from eslint-webpack-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.