Code Monkey home page Code Monkey logo

Comments (9)

jonn-set avatar jonn-set commented on June 21, 2024

@BorisOsipov Can you review this and merge it please?

from wdio-cucumber-framework.

jonn-set avatar jonn-set commented on June 21, 2024

Hi, its been 2 months, appreciate you guys are busy but can someone have a look at this merge request please?

from wdio-cucumber-framework.

BorisOsipov avatar BorisOsipov commented on June 21, 2024

@jonn-set would you mind adding unit test for this?

from wdio-cucumber-framework.

jonn-set avatar jonn-set commented on June 21, 2024

@BorisOsipov, sure, will do.

I ran through the existing tests and was wondering if there's a way to check that the right number of scenarios have been picked up using CucumberAdapter. It looks like all the tests call run function to execute the tests, which only return 0 or 1, is there something else that I can use as I don't really need to run the whole test, just make sure the right scenarios are filtered for testing.

Thanks

from wdio-cucumber-framework.

BorisOsipov avatar BorisOsipov commented on June 21, 2024

@jonn-set I am not ready to drive deep into current testing suite. I would like to have corresponding test at least to make sure we won't have regression in future with this fix

from wdio-cucumber-framework.

jonn-set avatar jonn-set commented on June 21, 2024

@BorisOsipov I have added some unit tests, have a look and if you are happy with it, please merge.

Thank you

from wdio-cucumber-framework.

jonn-set avatar jonn-set commented on June 21, 2024

@BorisOsipov, thanks for merging, when will this be released?

from wdio-cucumber-framework.

BorisOsipov avatar BorisOsipov commented on June 21, 2024

@christian-bromann ping

from wdio-cucumber-framework.

jonn-set avatar jonn-set commented on June 21, 2024

@christian-bromann, was this released?

from wdio-cucumber-framework.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.