Comments (7)
There are a few places where command line arguments can be added. The main one for Edge is here:
wpt/tools/wptrunner/wptrunner/browsers/edgechromium.py
Lines 41 to 46 in 2295a14
Due to the chrome_executor_kwargs
call, things added to Chrome will also apply to Edge. So if Chrome would have the same problem on Windows, I think adding the arguments to Chrome would make the most sense.
If this issue is somehow specific to the CI environment, another option is to add things here:
Line 412 in 2295a14
I don't think that's the case, but for Taskcluster we have some additional command line arguments for Chrome and Firefox, so it's a possibility.
from wpt.
Thanks @KurtCattiSchmidt! WebKit has apparently also disabled anti-aliasing for Ahem
: WebKit/WebKit@605fcea. So I think it's reasonable to go with approach (1).
from wpt.
Thanks @foolip, I will make these changes in WPT once my Chromium CL lands. This does indeed impact Chrome on Windows, so I'll make the change there too.
from wpt.
Thanks to @gastonrod for bringing this to my attention! CC @alisonmaher @bfgeek @drott
from wpt.
Can we explore combining 1 and 2 more? Safari still disables Ahem antialiasing without any flag guard. Firefox disables AA as a combination of a preference setting and a family name match.
I would find generally enabling this by family name a surprising effect, I am okay doing a combination of 2 and 1 (like FF): Disabling antialiasing for Ahem, under a flag guard, even if that unfortunately means the WPT runner configuration would have to be adapter.
@foolip, would you have any pointers as to where the WPT runner launch parameters for Edge on Windows can be configured?
from wpt.
@KurtCattiSchmidt have you been able to see if the fix worked yet?
from wpt.
@KurtCattiSchmidt have you been able to see if the fix worked yet?
Yes! I had to wait for the 126 release, which is now in Beta. The individual cases that I've been tracking are now marked as passing in Edge.
@foolip - is there an easy to determine exactly how many passes are due to this change?
from wpt.
Related Issues (20)
- SPAM
- Sukses
- Syntax error in core-aam tests
- [css-color] Tests assume old hsl()/hsla() clipping behavior or depend on unclear gamut mapping to sRGB HOT 9
- Add support for testing native find-in-page search results
- Are css/css-contain/contain-layout-baseline-005.html css/css-contain/contain-layout-button-001.html correct? HOT 9
- [css-color] css/css-color/parsing/color-computed-relative-color.html assumes conversion to hwb is lossless HOT 5
- The wpt Writing Tests documentation should be updated HOT 4
- infrastructure/testdriver/click_iframe_crossorigin.sub.html can fail in Firefox HOT 1
- REGRESSION(c3a572d): TypeError: can't compare offset-naive and offset-aware datetimes
- lint for tests with link rel=match and testharness.js
- Do not run tests for PRs still in draft mode HOT 1
- Fa
- Firefox Android runs missing since May 12
- tools/unittests (Python 3.12) are failing
- Lovely
- Azure Pipeline run queued and not restarted HOT 17
- iss
- tytg HOT 1
- WebVTT rendering tests fail widely because of UA-specific cue backgrounds HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wpt.