Expose promotion webhook via an ingress by default about clusters-config HOT 5 CLOSED

Thanks for the comments, we'll look into making pipeline-controller easier to troubleshoot.

from clusters-config.

Hi @yiannistri,
Is this something that should be enabled by default for all created clusters?

If this is something that shouldn't be enabled by default for all created clusters, I would recommend configuring it for the specific clusters by committing the changes to the cluster's branch.

from clusters-config.

Replied in Slack but posting it here too:

Because of how pipelines work, leaf clusters use the Flux notification-controller to make an HTTP call to the management cluster. This is a webhook endpoint that most of the time will need to be exposed.

For our team (sunglow) we'll have to always enable this because the pipelines feature depends on this, therefore it would save us a lot of time if this was enabled by default for all clusters. I have attempted to get this working on a test cluster but I'm unfamiliar with the right annotations for AWS LB/external dns and haven't got this working yet https://github.com/weaveworks/clusters-config/blob/cluster-manual-approval/eksctl-clusters/apps/enterprise/enterprise-app/release.yaml#L66-L80

from clusters-config.

Actually, you have done it right. There are 2 annotations that are not affecting the ingress, and it is working fine.

The 404 response is because the pipeline-controller itself is not working as expected. Try to get the server health by using /healthz it will return ok. https://promotions-manual-approval.eng-sandbox.weave.works/healthz

from clusters-config.

After we merge this PR, the creation of promotions ingress will be allowed by default. However, it will not be created until this WGE branch "approval-gate" is merged. Also, the pipeline-controller needs to be fixed as it returns 404.

from clusters-config.