Consider using namespace qualified tagged literals about integrant HOT 10 CLOSED

See also similar bug on aero: juxt/aero#44

from integrant.

Thanks for pointing this out. While edn says that tags should be prefixed, I have two reservations:

1. #integrant/ref is a quite a bit more to type than #ref
2. We're not really using the config file to communicate with anything other than Integrant

Remember also that:

(ig/read-string "foo.edn")

Is just a shortcut for:

(edn/read-string {:readers {'ref ig/ref}} "foo.edn")

And with Aero, you could write:

(defmethod aero/reader 'integrant/ref [_ _ value]
  (ig/ref value))

I think that in the rare circumstance that an un-namespaced #ref actually matters, you could instead use the edn/read-string function directly.

from integrant.

It's also worth pointing out that Datomic "cheats" in this fashion as well. In transactions, #db/id is used as a tag, rather than #datomic.db/id or #datomic/id. The rules are bent slightly for the purposes of brevity.

from integrant.

I've not looked at the details, but will your proposal work, if you have a file containing both aero and integrant refs? You should ideally be able to use the same tags in the same file, it's the whole point of edn being extensible.

Like integrant aero also defines a #ref, so how can you disambiguate an aero ref from an integrant one? Aero have agreed to prefix them with #aero/ref and support a deprecated legacy function for non prefixed ones (see juxt/aero#44 ), so the problem won't happen if they do that; but I think the burden is on all projects to namespace to prevent collisions such as this.

I'm all for bending the rules for brevity, aero plan to do it, and I'd certainly vote for an #ig/ref.

from integrant.

You can just give the integrant refs a different name. As I said in my previous comment:

(defmethod aero/reader 'integrant/ref [_ _ value]
  (ig/ref value))

So if you added that, you'd have #ref (or #aero/ref) for Aero refs, and #integrant/ref for Integrant refs. If you wanted brevity, you could also write:

(defmethod aero/reader 'ig/ref [_ _ value]
  (ig/ref value))

You can't use ig/read-string and aero/read-config together anyway, so there's no chance of it clashing by default, and since the configuration is a local resource, we don't expect anyone else to read it directly, either.

from integrant.

I just watched the CodeNode video and had the same concern about the unqualified #ref. The potential for real-world conflicts is admittedly small within the scope of integrant config files, but it could be worse if integrant-style data was incorporated into some larger data format or processed by external tools. Probably at this point, you don't want to change your notation or invalidate existing config files. Perhaps, as a compromise, you could add an additional qualified tag, like #ig/ref, as a documented option doing the exact same thing. That would only take a small addition to ig/read-string. It would allow people who care to follow the Clojure rules to do so, and still be able to share config data without requiring extra user code.

from integrant.

The issue with unqualified tags is that a future version of Clojure might define a meaning for the unqualified tag.

from integrant.

I don't have any problem with breaking backward compatibility in pre-1.0 versions, as long as there's a good reason. I'll think about this a little more.

However, I don't currently see there's any problem using #ref as the default data reader for integrant.core/ref. And if using #ref does become an issue, then it's trivial to switch to a different symbol for the data reader.

from integrant.

I just got around to looking at integrant and came here to file this issue. :)

In this particular case, of all the words you could pick, ref seems like it's near the top of the list as one of the most likely ones to conflict with potential core usage.

What about #ig/ref?

from integrant.

I'm leaning toward changing it to #ig/ref, but I'd like to think about it some more. In the meanwhile, it's trivial to change the data reader symbol to whatever you want; #ref is just the default.

from integrant.