IE8 error on line 124 about humane-js HOT 8 CLOSED

hmm interesting, are you use a legit IE8 or an emulator (IE8 mode)?

from humane-js.

We are using IE tester, but your page: http://wavded.github.com/humane-js/ works fine and does not report errors.

After doing as much as we can we have found that the error occurs when we pass the addnCls argument.

This works:

<script>
  var notify = humane.create({container: document.getElementById('notify')});
  notify.log("<h2>Order successfully submitted for 435645 of the Test Brochure</h2><p>You will be contacted shortly with confirmation of your order</p>", { timeout: 5000, clickToClose: false});
</script>

This fails:

<script>
  var notify = humane.create({container: document.getElementById('notify')});
  notify.log("<h2>Order successfully submitted for 435645 of the Test Brochure</h2><p>You will be contacted shortly with confirmation of your order</p>", { timeout: 5000, clickToClose: false, addnCls: "success"});
</script>

Sorry for the delayed response

from humane-js.

@LRotherfield I am having trouble duplicating, I setup your failing example here:

http://wavded.github.com/humane-js/test/issue38.html

I won't have access to a "real" IE8 machine until tomorrow (I'm using IE8 mode) but I can't seem to get that error to occur. Maybe try wrapping a try/catch around the problem line for now and see if that helps.

from humane-js.

@wavded We found the issue. Our css adds:

filter: progid:DXImageTransform.Microsoft.gradient( startColorstr='#c3dd8a', endColorstr='#9ebf69',GradientType=0 );

To the humane.success div. Removing this filter fixes the issue and explains why the error was reported with line 124, but means we cannot set a gradient background with css for ie 7 and 8.

from humane-js.

ahh good find, I had never attempted to add gradients to ie 7 and 8, does wrapping that line with a try/catch in humane allow you still use your gradients or does it cause other issues?

from humane-js.

I have not added a try/catch statement in as the fastest fix once I knew the issue was to use a background image instead. I will try tomorrow and let you know.

from humane-js.

@wavded I tried the try catch with nothing in the catch statement and it worked fine in ie8, no error message. Thanks for your help and sorry for the slow response. I have not added a pull request because I don't know if you want to do something with the catch statement or even if you want to implement this as a fix.

from humane-js.

@LRotherfield if it is beneficial for your case, it doesn't hurt to add it, at this point I'm not sure what I'd do with the catch except to "catch" the try :) if you'd like to submit a pull I'll add it

from humane-js.