Comments (7)
I've just checked and the changes are visible in the Github Repo. The commit that caused this hassle, was ea23084. Because of the fact that I'm the maintainer of this repo, I commit directly to the main branch without PR.
Your suggestion about making tags/releases with VS Code is a good one. I'll look into doing this in the future.
from addarr.
Same here.
from addarr.
@heisenberg2980 can you post an example of your config.yaml so we can see how you added those additional parameters? I am unclear on how to get things working again. Appreciate your help!
from addarr.
@heisenberg2980 can you post an example of your config.yaml so we can see how you added those additional parameters? I am unclear on how to get things working again. Appreciate your help!
https://github.com/Waterboy1602/Addarr/blob/master/config_example.yaml
For example: https://github.com/Waterboy1602/Addarr/blob/master/config_example.yaml#L17
from addarr.
I'm sorry for the experienced troubles. I didn't realise having restart: unless-stopped
in their config, would make the bot resending the messages endlessly.
Adding the missing parameters solved the issue, I am just creating this issue so other people having the same problem are aware of the solution, but my question is why are these parameters now mandatory? can these (and any other future new parameter added to the settings) be set as optional to avoid breaking changes? and why has this started happening just now if the last release of this package was done on October 2023?
I've chosen to make all settings mandatory. Just to prevent that some future update totally breaks the bot for some people. To prevent the loop of messages, i'll look into changing the feature so that the bot only sends one message even if the bot keeps restarting.
I went to dockerhub (https://hub.docker.com/r/waterboy1602/addarr) and I realised the package has been updated couple of days ago, how can the package be updated in dockerhub if there is no new tag/release in github?
This repo is configured to make a new Docker image with the push of every commit and not just with tags/releases. This because I don't really keep track of tags/releases and often forget to make new ones.
If you propose some way to make releasing new tags/releases less time consuming, I'll take a look into it.
from addarr.
@Waterboy1602 thanks for the clarification, my question was more about the package being updated in dockerhub without those changes being reflected in github. It seems that you have made the changes locally in your machine and not merged those changes to the github repo, which means github doesn´t contain the latest version of the code, so any pull request in github would be done against an old version of the code and not the latest, is my understanding correct?
And regarding the tags/release, I am not sure what IDE you use, but I believe Visual Studio Code with the "github pull request" extension allow you to create tags/releases when you commit the code to the repo
from addarr.
@Waterboy1602 you are completely right, please ignore my last comment as I must have completely missed that commit
from addarr.
Related Issues (20)
- Docker not starting HOT 6
- Authentication Error HOT 3
- Adding tags HOT 1
- TypeError: string indices must be integers, not 'str' HOT 7
- Authentication Issue: Incorrect Password Error in Group Chat HOT 1
- Add Support for qBittorrent Commands HOT 1
- Error at chosse Quality HOT 1
- Problem adding series at season selection HOT 1
- IndexError when search for movie title "The Ministry of Ungentlemanly Warfare" [BUG] HOT 1
- Config Problem HOT 2
- addarr does not raise from synology HOT 3
- Container failing when trying to add a movie HOT 6
- Adding a series flow HOT 12
- requests.exceptions.MissingSchema: Invalid URL 'None': No scheme supplied. Perhaps you meant https://None? HOT 1
- ValueError: max() arg is an empty sequence HOT 1
- Finds, but does not add series "Unfortunately, it was not possible to add the series. To start a new search, enter - films" HOT 14
- Can´t start the bot
- Add movie url
- sonarr bug
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from addarr.