Code Monkey home page Code Monkey logo

Comments (7)

passcod avatar passcod commented on May 17, 2024

Can you just use notify = "^2.1" as in current source, that should get the latest with the current Cargo.lock, your revision is technically same code and thus useless.

from cargo-watch.

passcod avatar passcod commented on May 17, 2024

Can you also provide the exact steps you use to make this segfault?

from cargo-watch.

fritzsche avatar fritzsche commented on May 17, 2024

I started by:

  1. git clone ....
  2. cargo build --release
  3. cp build/[...]/cargo-watch /usr/local/bin
  4. In project folder "cargo watch"
    --> On file change I get the segfault on MacOs (but works in Ubuntu)

I searched in the net and found above issues:
5) changed Cargo.toml to ensure notify contains the patch
notify = { git = "https://github.com/passcod/rsnotify.git", rev = "5a48333dde58a01f68c1e6" }
5) cargo update
6) cargo build --release
7) cp build/[...]/ /usr/local/bin
8) In project folder "cargo watch"
--> On file change still segfault. :-(

I also tried with notify master, but no difference. I have in also deleted old versions of cargo-watch /usr/local/bin to make sure no old version is remaining, also I tried "cargo clean" in between.

Version: macos el capitan
Rustc: 1.4

I'm novice to rust, sorry if I made something wrong.

from cargo-watch.

passcod avatar passcod commented on May 17, 2024

Moving discussion to notify-rs/notify#33 as this seems to be an upstream issue.

from cargo-watch.

octplane avatar octplane commented on May 17, 2024

@fritzsche can you verify that it is fixed, when building against:

notify = { git = "https://github.com/octplane/rsnotify.git", rev="5a9d08d94665b3d53f78f4a9aab2d9fa8e0d70f8" }

Thank you.

from cargo-watch.

fritzsche avatar fritzsche commented on May 17, 2024

This commit fixed the issue for me.

from cargo-watch.

octplane avatar octplane commented on May 17, 2024

Thank you @fritzsche . I am awaiting for peer reviews regarding the patch. I should land in rsnotify quickly. Thank you again for your report and validation!

from cargo-watch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.