JavaScript heap out of memory when importing about prettier-plugin-csharp HOT 7 CLOSED

No, I have no idea. While the plugin loads a generated parser, it’s not really memory-hungry. However, I’ve only tested it in Node, not in a browser.

Can you look at memory usage, see what kind of limit it hits? How did you get that stacktrace? What is the code running in? Did you really get Chrome to crash or that’s some sort of Electron environment?

from prettier-plugin-csharp.

It is a react application (create-react-app template). It uses webpack as a dev server and as the build tool.

This is the react app: https://github.com/jannikbuschke/csharp-script-runtime-and-editor/tree/master/app/web
In this file Im trying to format code with prettier/your plugin; https://github.com/jannikbuschke/csharp-script-runtime-and-editor/blob/master/app/web/src/scripts/execute-script.tsx

The stack trace is printed to the console when trying to start the react application in debug mode via npm run start.
Not sure how to pinpoint this kind of stuff.

from prettier-plugin-csharp.

I tested locally your project and was able to reproduce the issue. The crash occurs during compilation when including Prettier. Node process memory usage reaches 1.5 GB, whether you include the plugin or not (just call prettier.format(...) without the plugin options). I think it would be better to report this problem to the Prettier project instead of the plugin.

Still, I'm curious so I investigated. Raising the Node heap size is enough to fix the problem. See npm/npm#12238 (comment). Problem fixed in my environment: memory usage tops 2 GB and compilation succeeds.

I'm going to close the issue. Don't hesitate to re-open if you think the problem is related to the plugin.

Cool project by the way. Keep me updated if you manage to use prettier-plugin-csharp!

from prettier-plugin-csharp.

@warrenseine thanks for looking into this.
I created another repo https://github.com/jannikbuschke/-prettier-standalone-custom-parser to pinpoint the issue further.
One thing that I did wrong was to use the whole "prettier" package, whereas it should be "prettier/standalone".

In the new repo I use prettier/standalone with your plugin as well as with a graphql plugin. The graphql plugin works in both cases. The memory issue comes up only if the prettier-plugin-csharp is imported. Thats why I assume it has something to do with the build system and your plugin.

I created an issue in the prettier repo, but Im not sure where this really belongs to.

from prettier-plugin-csharp.

Tested again, and both projects on your new repository compile and run fine here.

from prettier-plugin-csharp.

Are you using node v12? I used v10 and now tested with v12 and it seems to work without changing the memory limit (--max_old_space_size=4096). I think this is because v12 allows more memory out of the box.

from prettier-plugin-csharp.

Indeed.

from prettier-plugin-csharp.