nvs basic auth accepts any user and pwd about lws-esp32-test-server-demos HOT 3 CLOSED

Thanks... I fixed that and otther lws breakage.

from lws-esp32-test-server-demos.

Tested the basic auth fix and it seems to work ok. Thanks!

Comment on "my code suggestion" on the nvs_open statement (for any potential reader who read this thread): I had the wrong assumption that nvs_open would not return an ESP_OK if the lwsdemoba never had been written before. This is not the case, so do not copy my code above.

If one would like to reduce flash write wear, I guess (me guessing again...) one could encapsulate the nvs_set and nvs_commit message with an additional "if(nvs_get_str(...) == ESP_ERR_NVS_NOT_FOUND) as the current progam will write to flash at every boot, even if it is not needed. I guess this can be interesting for applications which are expected to reboot the esp32 frequently.

from lws-esp32-test-server-demos.

Glad it's working.

Normally you'd only write the credential when you changed it, not every boot; the idea is normally the enduser selected the username / pw and you can't learn the credential by dumping the firmware. Because it's in nvs, it's also fine if the code setting the credential is in -factory or whatever.

Since the test demo is just a demo it just wants to show how to set the credential and how to make mounts require it in a standalone way.

from lws-esp32-test-server-demos.