Client: Generic type arguments about a2 HOT 5 CLOSED

Yeah, you keep the client alive a long time so forcing it into a lifetime doesn't make sense. Also you hopefully create connections rarely, so allocating from the heap doesn't hurt.

from a2.

Also, ToString (https://doc.rust-lang.org/std/string/trait.ToString.html) might be more appropriate than Into<String>, but I'm not 100% sure about that.

from a2.

A good point. I'll make the changes tomorrow when I have some time.

from a2.

Changed. I'll stick with the Into because I don't see much reason for ToString here. Yeah, of course the main use case here is to allow using &str or String, not that much anything else. Maybe even Cow would suffice.

from a2.

You do need an owned/allocated version of the string though, right?

I think Into is fine.

from a2.