Remove Redis dependency about wagtail HOT 3 CLOSED

Assigned to @spapas, discussing today with @spapas and @gasman.

from wagtail.

After an inspection of the code of wagtail and wagtail demo, I found out that Redis is used in two places:

a. As a django cache backend, in the wagtaildemo/settings/base.py. To remove the Redis dependency on development the Redis cache backed will be moved to production.py. Since no cache backend would be defined in base.py and dev.py the default django.core.cache.backends.locmem.LocMemCache backend will be used.

b. As a broker for celery, defined in wagtaildemo/settings/base.py. To remove the Redis dependency from here we can follow two paths:

i. Change base.py like this:

import djcelery
djcelery.setup_loader()
CELERY_ALWAYS_EAGER = True 

this way the tasks will be run synchronously so a broker won't be needed

and move the redis broker configuration to production.py

ii. A different path woul be to remove completely celery as a dependency from the development. Celery is only use in the wagtail / wagtail / wagtailadmin / tasks.py, and more specifically to decorate as a task the send_notification function. So, to remove both celery and redis dependencies completely we can conditionally (if DEBUG==False) decorate the send_notification method and also remove djcelery and kombu.transport.django from the base.py INSTALLED_APPS and only inclue them to the production.py.

I prefer method ii which removes both Redis and Celery. Any thoughts ?

from wagtail.

I like a. and b ii.

from wagtail.