Code Monkey home page Code Monkey logo

Comments (10)

igrigorik avatar igrigorik commented on May 13, 2024

@plehegar we have https://github.com/w3c/navigation-timing/blob/gh-pages/timing-overview.png checked in, which reflects all the right marks, but we have an SVG in the spec. Any objections to linking to the PNG? Do we have a doc / source for the png? Is that the PPT?

from navigation-timing.

igrigorik avatar igrigorik commented on May 13, 2024

Also missing: workerStart.

from navigation-timing.

plehegar avatar plehegar commented on May 13, 2024

No objection from me. The original drawing was indeed the PPT.

from navigation-timing.

igrigorik avatar igrigorik commented on May 13, 2024

I'm proposing we update NT with the following:

image

  • domLoading is part of NT1 and we deprecated it in NT2, hence that's a no-op.
  • Instead of replicating all of the RT timestamps, I propose we defer those to ResourceTiming (which includes workerStart)

The above would cleanly reflect what we define for PerformanceNavigationTiming and keeps things tidy between specs -- e.g. if we update RT, we don't have to duplicate diagram changes to NT.

@plehegar @toddreifsteck any objections?

from navigation-timing.

yoavweiss avatar yoavweiss commented on May 13, 2024

SGTM. Maybe also add a link to the corresponding RT diagram?

from navigation-timing.

igrigorik avatar igrigorik commented on May 13, 2024

Yeah, that one also needs to be updated and we can add a link to it in the figure caption.

from navigation-timing.

igrigorik avatar igrigorik commented on May 13, 2024

While working on updating the RT diagram... here's another variant with RT visible:

image

@toddreifsteck @plehegar any preference for one vs the other?

from navigation-timing.

toddreifsteck avatar toddreifsteck commented on May 13, 2024

I, personally, like the 2nd one. I recommend labelling the Resource Timings section by connecting the sections with a line wrapping both ends going down then joining on a Resource Timings label to make it clear. But... just my opinion. :-) @nolanlawson

from navigation-timing.

plehegar avatar plehegar commented on May 13, 2024

I like the 2nd one but it duplicates information with RT. We'll get it out of sync at some point in the future,...

from navigation-timing.

igrigorik avatar igrigorik commented on May 13, 2024

@plehegar in #52 I link to the source (in an HTML comment), which contains both diagrams.. Arguably, when they're in the same doc, it's easier to remember to keep them in sync. That said, I can be convinced either way.

@toddreifsteck I'll let you decide this one :) If you like #52, merge it. Otherwise, I can update it with the first diagram.

from navigation-timing.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.