Comments (6)
gkellogg
commented on September 22, 2024
Yes, this needs to be updated. The omitGraph flag defaults to true in 1,1 mode, which is the default. Set it to false to get the @graph back, or use the 1.0 processor mode for the implied false value.
from json-ld-framing.
Fak3
commented on September 22, 2024
Btw, I find the name of the flag a bit complicated to understand because of double-negation. I.e. in my mind "omit" means "don't include", and I always have to perform this mental exercise to parse 'don't include graph is False' into 'include graph'. Does anyone feels the same nuisance? Would it help to rename it to includeGraph?
from json-ld-framing.
iherman
commented on September 22, 2024
This issue was discussed in a meeting.
RESOLVED: Update examples 4 & 5 in Framing to be instructive as well as correct and close when updated
View the transcript
omit graph exampleRob Sanderson: #88
Gregg Kellogg: The issuer pointed out that we are using double negation, as omitGraph true is the default.
… It made more sense in 1.0. But now the default value is reversed.
… We could rename it in 1.1.
Rob Sanderson: We probably don’t want to rename it to includeGraph?
Proposed resolution: Update examples 4 & 5 in Framing to be instructive as well as correct (Rob Sanderson)
Rob Sanderson: We should update the examples in framing to be more instructive.
… This is just editorial.
Proposed resolution: Update examples 4 & 5 in Framing to be instructive as well as correct and close when updated (Rob Sanderson)
Ivan Herman: +1
Rob Sanderson: +1
Tim Cole: +1
Ruben Taelman: +1
Jeff Mixter: +1
Adam Soroka: +1
Pierre-Antoine Champin: +1
Gregg Kellogg: +1
Resolution #3: Update examples 4 & 5 in Framing to be instructive as well as correct and close when updated
from json-ld-framing.
gkellogg
commented on September 22, 2024
@Fak3, please see updated text in PR #91. Please indicate if this satisfies your issue.
from json-ld-framing.
Fak3
commented on September 22, 2024
Yes, this resolves the issue, thanks
from json-ld-framing.
gkellogg
commented on September 22, 2024
Reopened for WG to dispose of.
from json-ld-framing.
Related Issues (20)
- Should tests for `@embed`: `@last` be restricted to JSON-LD 1.0? HOT 4
- Framing and Arrays HOT 4
- Ex. 41 Playground doesn't contain `@omitGraph: false` + playground does not apply `@omitGraph` HOT 3
- Pattern Matching HOT 4
- Can frames produce id maps? HOT 2
- Possible typos HOT 2
- Use a property several time when framing HOT 1
- validation errors/warnings HOT 1
- Language map with global context HOT 1
- IANA profile should be `frame` not `framed` HOT 5
- how to use the `frame` and `framed` profiles? HOT 12
- Fix invalid WebIDL HOT 1
- Change "Lexicographical Order" (and related) to "Unicode code point order". HOT 1
- Possible bug with `@json` being treated as invalid `type` in frame HOT 24
- How to use specific value inside a frame to filter out credentials those do not contain that value
- Framing on nested graphs
- Add test for `@graph` keyword aliasing
- more JSON-LD framed examples for performance testing
- Framing to a default language for the entire doc HOT 5
- test GH action
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from json-ld-framing.