Code Monkey home page Code Monkey logo

Comments (7)

iherman avatar iherman commented on June 16, 2024

This issue was discussed in a meeting.

  • RESOLVED: Keep #37 open for @omit-graph
View the transcript 3.1. Keywords for options
Simon Steyskal: #37
Rob Sanderson: ivan asks why there isn’t a keyword for all the different options
Ivan Herman: I realized by reading through the document that certain options appeared as keywords
… others don’t
Gregg Kellogg: I think there are if you look at the syntax tokens
Gregg Kellogg: https://w3c.github.io/json-ld-framing/#framing-keywords
Ivan Herman: not sure I remember reading this
Gregg Kellogg: we very well may have examples that don’t use all the keywords
Rob Sanderson: > Initialize flags embed, explicit, and requireAll from object embed flag, explicit inclusion flag, and require all flag in state overriding from any property values for @embed, @explicit, and @requireAll in frame.
Ivan Herman: yeah the examples in the syntax document were way more extensive
Dave Longley: was just going to say our implementation has those flags in there (and there may be tests as well… at least i hope so) :)
Gregg Kellogg: my thought initially was that framing would eventually be incorporated in the API document
… but we decided to leave it in a sep. doc
… so there’s a backlog of things that have to happen to the document
Tim Cole: Does 4.1 include @omit-graph?
Ivan Herman: clearly, if we add more examples to the document then this should fix it
Proposed resolution: Close Framing #37, as already fixed (Rob Sanderson)
Gregg Kellogg: there is an open issue I’m working against
Rob Sanderson: +1
Pierre-Antoine Champin: +1
Gregg Kellogg: no it’s in 4.4.3.3
Benjamin Young: is it a keyword? or an option for the api?
Gregg Kellogg: well we have keywords for all the options
Proposed resolution: Keep #37 open for @omit-graph (Rob Sanderson)
Simon Steyskal: +1
Ivan Herman: +1
Rob Sanderson: +1
Tim Cole: +1
Benjamin Young: +1
Dave Longley: +1 … naming convention appears to be camelCase so @omitDefault
Gregg Kellogg: +1
Gregg Kellogg: values can have multiple elements (array) part of the reason why this complicates native json support
David I. Lehn: +1
David Newbury: +1
Resolution #2: Keep #37 open for @omit-graph

from json-ld-framing.

gkellogg avatar gkellogg commented on June 16, 2024

I'm not sure @omitGraph would be particularly useful, as it is only useful at the very top-level and the algorithm doesn't consider it as a possible default when processing a frame object.

Note that it defaults to true in 1.1, which is probably what most people want. Adding it to the frame is kind of odd, though.

from json-ld-framing.

iherman avatar iherman commented on June 16, 2024

True. But I guess it would require more explanation to describe why this (or other) API flag does not have a keyword equivalent... Furthermore, by using this keyword (and others) the creator of a frame ensures that this statement is always there, regardless of how a particular JSON-LD processor is invoked, ie, how the API flags are set...

from json-ld-framing.

gkellogg avatar gkellogg commented on June 16, 2024

See #41, which would remove @omitDefault while possibly keeping the flag.

In the case of the omit graph flag, it is never encountered when processing a frame, and it would require something extra to reach into the frame to see if this had been set. The default in 1.1 is to omit it, and the flag mostly exists to be able to explicitly go back to the 1.0 behavior.

from json-ld-framing.

azaroth42 avatar azaroth42 commented on June 16, 2024

So we can close?

from json-ld-framing.

azaroth42 avatar azaroth42 commented on June 16, 2024

Closed by resolution: https://www.w3.org/2018/json-ld-wg/Meetings/Minutes/2019/2019-03-29-json-ld#resolution4

from json-ld-framing.

iherman avatar iherman commented on June 16, 2024

This issue was discussed in a meeting.

  • RESOLVED: Close #37, only edge edge cases when there is disparity
View the transcript 4.5. Keywords / Flags
Ivan Herman: link: #37
Rob Sanderson: would we have complete parity between keywords and flags?
Proposed resolution: Close #37, only edge cases when there is disparity (Rob Sanderson)
Rob Sanderson: +1
Ivan Herman: we have the parity for most of them;
Ivan Herman: +1
Dave Longley: +1
Ruben Taelman: +1
Gregg Kellogg: +1
Tim Cole: +1
Ivan Herman: those were we don’t are edge cases, so I’m fine with closing it
Pierre-Antoine Champin: +1
David Newbury: +1
David I. Lehn: +1
Resolution #4: Close #37, only edge edge cases when there is disparity
Adam Soroka: +1

from json-ld-framing.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.