Comments (3)
@davebm1 I think you're right but I never got really down to the root cause/which way we should do mutate/fetch.
Can you investigate the root cause and what's the best way to do "mutate local + fetch"? We're using https://github.com/vercel/swr
It's true that on my own app code I tend to do mutate and then await fetch instead of await end then fetch.
Then we can safely update the example code here and in the Next.js repo (https://github.com/vercel/next.js/blob/canary/examples/with-iron-session/pages/login.js)
from iron-session.
The promise is returned from fetch, not from swr, so mutate..await..fetch seems the better option.
This approach seems to be supported on the swr npm page https://www.npmjs.com/package/swr
with a couple of examples:-
Section: Mutate Based on Current Data:-
mutate('/api/users', async users => {
const user = await fetcher('/api/users/1')
return [user, ...users.slice(1)]
})
and
section: Prefetching Data:-
function prefetch() {
mutate('/api/data', fetch('/api/data').then(res => res.json()))
// the second parameter is a Promise
// SWR will use the result when it resolves
}
The next-iron-session example also uses await this way for logout in
https://github.com/vvo/next-iron-session/blob/master/examples/next.js/components/Header.jsx
onClick={async (e) => {
e.preventDefault();
mutateUser(
await fetchJson("/api/logout", { method: "POST" }),
false,
);
router.push("/login");
}}
I was getting intermittent authentications problems with await..mutate..fetch with failure to redirect
after authentication. This was resolved by changing to mutate..await..fetch.
Regards...
from iron-session.
Thanks, just updated the examples 🙏
from iron-session.
Related Issues (20)
- TypeError: res.getHeader is not a function HOT 2
- Package causing multiple response problem HOT 1
- v8 beta release, last tasks and discussions HOT 6
- session object empty on Apollo Server API Route
- Can i use iron-session with pages routes ? HOT 1
- Implementing iron-session with TRPC HOT 9
- Session cookie not created when static web app is sitting behind azure front door due to domain mismatch HOT 3
- Static maxAge
- v8 - Attaching session to request HOT 1
- Make properties in T for IronSession<T> optional (union with undefined)
- v6 and Next 13 pages middleware HOT 7
- Migration away from `withIronSessionApiRoute` HOT 3
- await session.save() fails to set cookie if cookies.set() is used after HOT 2
- session returned from `getIronSessionFromCookieStore` does not implement full interface HOT 1
- outdated dependency @types/cookie causes type mismatch HOT 1
- why getIronSession not work in middleware like in example (App router + client components, route handlers, and SWR) HOT 3
- Support the `partitioned` attribute in cookie settings HOT 1
- Discrepancy in documentation of password rotation. HOT 5
- Next.js middleware token rotation issue HOT 3
- Unable to create a session cookie HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from iron-session.