Comments (6)
Sounds great! I don't have any rigid guidelines about how to manage the CSS, but if you're going to use SASS/Compass I generally stick to these rules:
- Separate styles in many files
- Try not to nest CSS declarations too deep
- Make good use of mixins and other SASS/Compass features to make code easier to maintain
- Prefix CSS classes with the element they apply to (i.e.
post-comment
,post-title
,post-share
, etc.) - Use Twitter Bootstrap class names and markup whenever possible even if I'm not actually using Bootstrap myself, to keep things standard and make it easier to use it if you want to.
- Never use IDs in CSS
- Try to keep structural and visual CSS code separate (although in practice that's really hard to do)
I think you can either build on my CSS or start from scratch. Telescope uses a lot of repeating elements so it's not as big a task as it might seem.
In any case, you can ping me on skype (username: SachaGreif) or contact me through my site if you want to discuss this more.
from vulcan.
On a related note, I'm planning to make colors easily customizable through the settings panel later on. Maybe something to keep in mind for your redesign.
from vulcan.
Hi,
We've tweaked the styling and display in this fork: https://github.com/Inneo/Telescope
There are a bunch of structural and styling changes throughout the clients/ folder, with an overall goal of writing more modular CSS. For instance, we:
- moved everything to fluid width and got rid of most @media queries
- started moving all colors to the variables.scss file (which should help with making colors an admin option)
- tried to move to relative and percentage-based spacing where possible
- implemented a more consistent layout of header > section > section > section > footer, each with a centered wrap
- tried to cleanup the header menus, to prevent overlaps
Please look our fork over, and let me know if you'd like me to commit any of it upstream.
Thanks,
~Cooper
from vulcan.
Wow, that sounds great! I'll take a look as soon as I can and get back to you. I'm not sure about having everything be fluid width, but other than that those all sound like things I should've done myself a long time ago. So thanks!
from vulcan.
I don't know if I'll have time to look at the changes one by one, but it would be great if you could submit a pull request with all the changes that are purely functional (i.e. moving all colors to variables.scss) and not cosmetic (i.e. getting rid of the mobile version and media queries). Basically, I would prefer keeping the site the same visually, at least for now.
But if that's too much work, maybe you can just keep working on your fork and I'll reintegrate your best ideas manually in the master branch later on.
from vulcan.
I'm going to do a better job of managing the Telescope community in 2013.
For starters, I've just created a new instance of Telescope where the
community can discuss features and ask questions:
Of course you can keep using GitHub as well, especially for bug reports.
On Fri, Dec 21, 2012 at 4:09 PM, Cooper Dukes [email protected]:
Hi,
We've tweaked the styling and display in this fork:
https://github.com/Inneo/TelescopeThere are a bunch of structural and styling changes throughout the
clients/ folder, with an overall goal of writing more modular CSS. For
instance, we:
- moved everything to fluid width and got rid of most @mediahttps://github.com/mediaqueries
- started moving all colors to the variables.scss file (which should
help with making colors an admin option)- tried to move to relative and percentage-based spacing where possible
- implemented a more consistent layout of header > section > section >
section > footer, each with a centered wrap- tried to cleanup the header menus, to prevent overlaps
Please look our fork over, and let me know if you'd like me to commit any
of it upstream.Thanks,
~Cooper—
Reply to this email directly or view it on GitHubhttps://github.com/SachaG/Telescope/issues/59#issuecomment-11604507.
from vulcan.
Related Issues (20)
- Input filter operator _nin is not yet implemented HOT 7
- Support "reverse belongsTo" relations HOT 1
- query results are undefined during loading (due to breaking change in @apollo/client v3) HOT 11
- Migrate cache to Apollo v3 HOT 2
- Renaming Material UI base form controls HOT 12
- Cannot use SmartForm for creating new documents SmartForm.submitForm
- Smartform shows delete button regardless of collection.permissions.canDelete HOT 3
- RTL support for UI by adding top level class in HTML HOT 4
- Add more flexible low level GraphQL checks HOT 2
- objectSpread2 error after running unit test HOT 2
- Nested Schema document update not working HOT 2
- How do we coordinate work among Vulcan contributors? HOT 1
- useCookies is not a function or its return value is not iterable HOT 2
- I can't run the project Vulcan(Lubuntu) HOT 8
- collection.addField not working if schema is simpl-schema HOT 3
- Relations hasMany bug. HOT 12
- Duplicate Item with withMulti HOT 4
- Add className to FormComponentLoader
- Attempting to implement multiple interfaces on a type causes an error HOT 3
- Error: Cannot find module '@graphql-tools/utils'
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vulcan.