Reproc and "Bad (Needs Edits)" show up as a good cassr about dax HOT 9 CLOSED

Hmm, that should be added with the pull request dax_test we added. Let me check.

from dax.

Ah I miss read the comment. hmm what is this issue again?

from dax.

wat?
On Fri, May 6, 2016 at 10:19 AM Benjamin Yvernault [email protected]
wrote:

Hmm, that should be added with the pull request dax_test we added. Let me
check.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#68 (comment)

from dax.

It's a case sensitive issue. The case of the qcstatus on XNAT in sent to .lower() though the qc status list is not.

In [3]: BAD = ['Failed', 'Bad', 'Poor', 'Do Not Run']

In [4]: qcstatus = 'Bad (Needs Edits)'

In [5]: for qc in BAD:
...: if qc in qcstatus.split(' ')[0].lower():
...: print "BAD QC"
...:

In [6]: 'Bad' in 'bad'
Out[6]: False

from dax.

Throwing .lower() in qc fixes the issue

from dax.

Steve, I'm looking into this. Are you referring to is_bad_qa() in XnatUtils ?

from dax.

Am I looking at this correctly? is_bad_qa returns 1 if the status is good? Seems backwards.
And is there any case where the current implementation will ever return -1?

from dax.

#72

from dax.

Done

from dax.