Code Monkey home page Code Monkey logo

Comments (2)

Furgas avatar Furgas commented on August 16, 2024

My quick&dirty "fix":

     #[Route(
         '/zipball/{package}/{hash}',
         name: 'download_dist_package',
-        requirements: ['package' => '%package_name_regex%', 'hash' => '[a-f0-9]{40}\.[a-z]+?'],
+        requirements: ['package' => '%package_name_regex%', 'hash' => '.+?\.zip'],
         methods: ['GET']
     )]
     public function zipballAction(#[Vars('name')] Package $package, string $hash): Response
     {
         if ((false === $this->dm->isEnabled() && false === RepTypes::isBuildInDist($package->getRepoType()))
-            || !\preg_match('{[a-f0-9]{40}}i', $hash, $match) || !($reference = $match[0])
+            || !\preg_match('{(.+?)\.zip}i', $hash, $match) || !($reference = $match[1])
         ) {
             return $this->createNotFound();
         }

After this fix I also had to disable include_archive_checksum option in config, because sha1 checksums were wrong for Subversion packages . I don't know why yet.

from packeton.

Furgas avatar Furgas commented on August 16, 2024

Strangely enough, it works on my development machine, but in docker the starting slash is missing (tags/1.0.1/@3426.zip instead of /tags/1.0.1/@3426.zip) so I had to also add:

if (str_contains($reference, '/') && !str_starts_with($reference, '/')) {
    $reference = '/' . $reference;
}

I'll analyze later what is the root cause.

from packeton.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.