Comments (4)
Just some summary notes for myself when I return to this;
- Between XE5 to XE7 protected and private methods WillExecute no longer works.
- This is an object mocking issue.
- The called method is protected on a TComponent descendant.
from delphi-mocks.
Thanks for reporting this. Thinking about this now I would have expected it to break when we changed the virtual interface class and its method of execution. I will have to write some tests around this to verify my thoughts.
Another issue that this raises is the scope of Delphi-Mocks. Honestly I must say the limits I had placed on mocking were the following;
- Allow mocking of all interfaced methods.
- Allow mocking of virtual public class methods.
The main reason for this was two fold;
- To limit the work required by the mocking library.
- Unit testing is typically (and I know people have historical applications built other ways) is about testing a single unit of code. Mocking helps "fake" external functionality of other objects used in single unit of code.
I can understand the desire to mock a data object, however is testing that the dataobjects internals are triggered by the single unit of code going a step too far?
Also please let me know if my thinking around the use case here is not correct. From my understanding the mock is being used something like this;
found := sutDataConsumer.FindXItem(FMockDO, X);
Assert.IsTrue(found, "FindXItem should have found X in dataset FCDS1");
Currently my belief is that this should be a use case as certain controls, and 3rd party tools don't expose the ability to mock their public interface. Therefore extending my "Allow mocking of virtual public class methods" to be "Allow mocking of any virtual methods".
Anyone else have any other thoughts?
from delphi-mocks.
@GallaherMike Since you mention that you upgraded von XE5 to XE7 - could it be that the $RTTI directive is not in the same unit as your class and that it worked in XE5 because of this bug? http://qc.embarcadero.com/wc/qcmain.aspx?d=79943
I cannot reproduce the behavior you are describing when putting the $RTTI directive right above my TDataObject class because the RTTI contains it.
Anyhow from my point of view mocking private methods is not the best way to do - you should rethink your architecture.
from delphi-mocks.
Closing this since mocking private and protected methods is really not a good idea, since (without hackery) code using those instances is really only calling it's public interface.
from delphi-mocks.
Related Issues (20)
- Some questions rather than an issue HOT 3
- Get rid of W1029 warning in Delphi compile mode HOT 4
- Need research if IStubSetup<T> can benefit from an overloaded method function WillReturn<TReturn>(const value : TReturn) : IWhen<T>; overload; HOT 2
- Memory leak there should not have memory leak HOT 2
- Typos in Sample1Main.pas HOT 1
- Status of Delphi XE support HOT 2
- Mocking an empty interface HOT 2
- TObjectProxy.Destroy raises "Invalid pointer operation". HOT 1
- Typo on Delphi.Mocks.Proxy.pas
- Some units have (apparently unnecessarily) Windows in the uses clause HOT 3
- Mock Objects HOT 1
- Remove copy of VSoft.WeakReference and use dpm package
- [discussion] Delphi Mock documentation HOT 7
- TMock<IMyInterface>.MyMethod(X) leads to access violation when X is a record type HOT 3
- Test fails with current version of Mocks, passes with old version HOT 2
- Calling virtual method with defined behavior can cause problems HOT 2
- Example code does not work HOT 1
- Not able to define behaviour for overloaded functions with different parameters. HOT 1
- WillReturn for public class property with private getter HOT 4
- Call to actual class method when mocking class with a non-virtual method HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from delphi-mocks.