Wrong quoting for local-data TXT records about puppet-unbound HOT 5 CLOSED

Sorry, I was wrong! The quoting can be set by the caller for arrays.

from puppet-unbound.

Not a worry, glad you sorted it out.

from puppet-unbound.

I stumbled on the same problem and I don't understand what you were meaning by:

The quoting can be set by the caller for arrays.

As far as I can see, the double quotes are hardcoded in the erb template:

So how do you handle TXT records containing double quotes and spaces (like DKIM records) ?

Thanks in advance for your help.

from puppet-unbound.

My comment above

Sorry, I was wrong! The quoting can be set by the caller for arrays.

was for the local-data part in the templates/unbound.conf.erb:

If you hand over something like this:

$local_data = [
    "'mail._domainkey.example.com 14400 IN TXT \"v=DKIM1;h=sha256;k=rsa;\"\"p=DKIM_KEY_PART_1\"\"DKIM_KEY_PART_2\"'"
]

to the unbound class:

class { '::unbound':
    …,
    local_data => $local_data,
    …,
}

you will get, what you want.

For the quoting in templates/local_zone.erb you are absolutely right. So my comment above was right by accident:

I would suggest to use single quotes for all local-data entries.

But I would suggest to do this on all local-data config locations

from puppet-unbound.

Thanks a lot for your answer. I identified two ways to insert local-data (local_zone and record) but I missed the third one :-)
May be I will propose a pull request to automatically single quote TXT records and split them into pieces of 255 characters.

from puppet-unbound.