Cyclic dependency error when using systemd::unit_file in multiple classes about puppet-systemd HOT 3 CLOSED

Hi!
I thought a bit about this. If you set active to true on the systemd::unit_file defined resources, it creates the service resource for you:
https://github.com/camptocamp/puppet-systemd/blob/8f68b0dcf3bbbafc60c025879a28004fc9815aab/manifests/unit_file.pp#L91-L98

You basically define the service twice, once in your profile and once via the defined resource. This works by accident because the defined resource references the service with send_downtime.service and the profile with send_downtime. This means that you could shorten the profiles:

class profile::monitoring {
  systemd::unit_file { 'send_downtime.service':
    content => file('profile/send_downtime.service'),
    active  => true,
    enable => true,
  }
}

class profile::base_os {
  systemd::unit_file { 'remove_check_mk_cache.service':
    content => file('profile/remove_checkmk_cache.service'),
    active  => true,
    enable => true,
  }
}

While this is shorter, it indeed creates the dependency loop you mentioned. On a few of my profiles I workaround this by not ordering the profiles like you did in your role. I set explicit dependencies in my profile to resources to the other profiles. In your case that would mean:

class profile::monitoring {
  systemd::unit_file { 'send_downtime.service':
    content => file('profile/send_downtime.service'),
    active  => true,
    enable => true,
  }
  Service['remove_check_mk_cache.service'] -> Service['send_downtime.service']
}

class profile::base_os {
  systemd::unit_file { 'remove_check_mk_cache.service':
    content => file('profile/remove_checkmk_cache.service'),
    active  => true,
    enable => true,
  }
}

But I understand that ordering profiles in a role is a common pattern and I do that myself alot as well. In that case just remove the active => true, line from your two systemd::unit_file and all works as well.

from puppet-systemd.

Fix is available in #171

from puppet-systemd.

#171 has been merged so I think this can be closed now.

from puppet-systemd.