Comments (6)
That could be interesting indeed. Do you want to provide a PR with such a shellvar::bulk
wrapping definition?
from puppet-augeasproviders_shellvar.
I would but... sadly I don't think I know enough Ruby to add a function that does that. If I did it as a define() then it wouldn't have the performance benefit.
from puppet-augeasproviders_shellvar.
I was actually thinking of a DSL define. How would you expect to see performance benefit?
from puppet-augeasproviders_shellvar.
On the performance issue: since puppet 3.4, augeasproviders use a shared Augeas handler for all resources. Hence, Augeas is only started once, and only parses target files twice as most (one read to fill the tree, a second read to calculate the diff if changes were made, and one write to flush changes if any). All you need is to use puppet 3.4+. The only overhead to using separate resources currently is stuff done entirely in memory, so the gain wouldn't be great.
from puppet-augeasproviders_shellvar.
Oh, so the optimization is already in there. That's awesome!
I'll see if I can work up a DSL define.
from puppet-augeasproviders_shellvar.
Actually, the lib still saves the Augeas tree once per modified resource (vs once per modified property). I don't think it would be good to change this though, as that would mean that if a resource produces an invalid tree, all resources of that file will fail to apply.
from puppet-augeasproviders_shellvar.
Related Issues (20)
- Exporting array value fails HOT 1
- Shellvar doesn't work on Debian Squeeze HOT 10
- Cannot use both comment = "" and uncomment = true HOT 3
- problem with exclude in yum.conf HOT 2
- Add `alias` to ensure value HOT 3
- shellvar doesn't work properly for export HOT 4
- undefined method `split' for nil:NilClass when file contains managed variable name in comments with no assignment
- rspec Unknown resource type: 'shellvar' HOT 3
- Error with Puppet 5.3.3 HOT 2
- Add support for 'puppet generate types' HOT 1
- Cannot alias Shellvar, resource already declared HOT 6
- Support for Puppet 2019.x ? HOT 1
- shellvar crashes
- support ensure => sourced HOT 2
- Puppet7 support HOT 1
- shellvar: array + quoted not working HOT 1
- shellvar: quoted does not converge HOT 1
- Shellvar comment parameter make a mess of existing comments HOT 1
- shellvar: export + comment requires two passes HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from puppet-augeasproviders_shellvar.