Code Monkey home page Code Monkey logo

Comments (41)

TomPoulton avatar TomPoulton commented on August 16, 2024

v1.3.6 published

from hiera-eyaml.

sihil avatar sihil commented on August 16, 2024

Good work @TomPoulton - turns out I screwed up in a couple of places, so if you get time to merge #42 and #43 and release a new version, that would be helpful :) I've checked both fixes and confirmed they work.

from hiera-eyaml.

TomPoulton avatar TomPoulton commented on August 16, 2024

v1.3.7 published

from hiera-eyaml.

sihil avatar sihil commented on August 16, 2024

Thanks :)

from hiera-eyaml.

TomPoulton avatar TomPoulton commented on August 16, 2024

v1.3.8 is up which includes recryption, merging and configurable file extensions thanks to #44, #48 and #46 respectively!

from hiera-eyaml.

gtmtech avatar gtmtech commented on August 16, 2024

@TomPoulton Just to let you know, you have at least 6 failing tests, so it would be better to fix them first before creating a new gem.

See TravisCI output for what they are.

from hiera-eyaml.

gtmtech avatar gtmtech commented on August 16, 2024

I've merged a simple README.md file change which allows you to see the current status of TravisCI on the main site page - scroll down to the readme to see it.

Note that it's failing at the moment. We need to fix this as a priority and always keep the tests going green.

from hiera-eyaml.

TomPoulton avatar TomPoulton commented on August 16, 2024

Yeah the tests should pass before we add any feature additions/changes.

I pushed a change just now to stop some of the steps timing out so I guess that the other errors are a result of running within Travis rather than code issues (although that is pure speculation and I'll probably end up eating my words) I only pushed the gem because the tests ran locally, but all future gems will only be pushed if Travis says so!

from hiera-eyaml.

gtmtech avatar gtmtech commented on August 16, 2024

Great stuff.. admittedly I hadn't been able to look at this project for a couple of weeks, but the tests are failing for me locally on a brand new clone too, so I think there are some errors to fix. Think @sihil is looking at the failing tests. I'm going to work on the remaining outstanding issues/improvements.

See we've got ~4000 downloads. Not too bad - worth writing a few blog articles about this project I think so people are ware there is an alternative to hiera-gpg.

It would also be great if @sihil could write or reference an example workflow for hiera-gpg multiple developer key management in the Wiki. I'd really like to learn how its done 👍

from hiera-eyaml.

rooprob avatar rooprob commented on August 16, 2024

We're doing multiple key management with the hiera-eyaml-gpg. I'm just
writing up for our team. Will come back with something if you like.

Cheers,

On Tue, Nov 19, 2013 at 10:46 AM, Geoff Meakin [email protected]:

Great stuff.. admittedly I hadn't been able to look at this project for a
couple of weeks, but the tests are failing for me locally on a brand new
clone too, so I think there are some errors to fix. Think @sihilhttps://github.com/sihilis looking at the failing tests. I'm going to work on the remaining
outstanding issues/improvements.

See we've got ~4000 downloads. Not too bad - worth writing a few blog
articles about this project I think so people are ware there is an
alternative to hiera-gpg.

It would also be great if @sihil https://github.com/sihil could write
or reference an example workflow for hiera-gpg multiple developer key
management in the Wiki. I'd really like to learn how its done [image:
👍]


Reply to this email directly or view it on GitHubhttps://github.com//issues/37#issuecomment-28741273
.

from hiera-eyaml.

rooprob avatar rooprob commented on August 16, 2024

PS on the timeouts: I was getting these on the puppet tests with 1.3.4 and
forgot about them after I resolved all my merges for 1.3.6.
The patch to add a 10 second timeout in was the same thing I did to fix.

54b75e6
@aruba_timeout_seconds = 10

On Tue, Nov 19, 2013 at 10:54 AM, Rob Fielding [email protected] wrote:

We're doing multiple key management with the hiera-eyaml-gpg. I'm just
writing up for our team. Will come back with something if you like.

Cheers,

On Tue, Nov 19, 2013 at 10:46 AM, Geoff Meakin [email protected]:

Great stuff.. admittedly I hadn't been able to look at this project for a
couple of weeks, but the tests are failing for me locally on a brand new
clone too, so I think there are some errors to fix. Think @sihilhttps://github.com/sihilis looking at the failing tests. I'm going to work on the remaining
outstanding issues/improvements.

See we've got ~4000 downloads. Not too bad - worth writing a few blog
articles about this project I think so people are ware there is an
alternative to hiera-gpg.

It would also be great if @sihil https://github.com/sihil could write
or reference an example workflow for hiera-gpg multiple developer key
management in the Wiki. I'd really like to learn how its done [image:
👍]


Reply to this email directly or view it on GitHubhttps://github.com//issues/37#issuecomment-28741273
.

from hiera-eyaml.

gtmtech avatar gtmtech commented on August 16, 2024

That would be awesome @rooprob !

from hiera-eyaml.

sihil avatar sihil commented on August 16, 2024

Fantastic work by all - really pleased to see this tool gaining some traction. On that note I do intend to write a blog post soon and would like to get it mentioned in devops weekly (if you don't already subscribe, check out http://devopsweekly.com/).

Before that however, I think we should make it super clear in the README.md what our USP is and the benefits of hiera-eyaml over hiera-gpg and hiera-yamlgpg. In my view it is the per value encryption and the tooling around editing. I'll try and suggest some changes to the README to encompass that.

Just off to look at the failing build - works in both my local environments, which is confusing.

from hiera-eyaml.

sihil avatar sihil commented on August 16, 2024

I think the main reason the travis build is failing is that is is using an old version of hiera-eyaml, not the one from the code. It is installing hiera-eyaml 1.3.4 as part of the bundle task (possibly as a dependency of hiera-eyaml-plaintext?). The failures of the scenarios in edit expose the behaviour difference, 1.3.4 didn't include numbered references but newer versions do.

I'm going to carry on trying to get to the bottom of this. I've also created a #hiera-eyaml channel on freenode that I'm hanging out in if that's your thing.

from hiera-eyaml.

sihil avatar sihil commented on August 16, 2024

Yep - I've managed to reproduce the failure by doing a bundle install --deployment followed by a bundle exec cucumber -f progress. Turns out it is because we are including an old gem in the bundle install (it's in the Gemfile.lock file) and we are testing the gem instead of the code base. Oops.

Short term fix in #52. Longer term fixes up for grabs.

I'm in #hiera-eyaml on freenode if that's your thing. I'm going to carry on casually mentioning this at the end of messages on github until someone joins me ;)

from hiera-eyaml.

TomPoulton avatar TomPoulton commented on August 16, 2024

I did a search for "hiera-eyaml" the other day just to see what the general feeling was in the community and if there were any issues we didn't know about, I only found a couple of mentions but they were all positive and interestingly mainly presented it as an alternative to hiera-gpg!

Like @sihil said, the main USP is the transparency of where each value is being set/overridden (i.e. per value encryption), that's the reason I wrote it in the first place, but the eyaml tool itself is now a major feature and provides huge wins to anyone using hiera-eyaml, plus it's just cool!! I think we should also highlight the asymmetric encryption part, just to make sure people are aware that only the Puppet Master has the ability to decrypt the data, but anyone can encrypt!

from hiera-eyaml.

TomPoulton avatar TomPoulton commented on August 16, 2024

So I pushed some code to a new branch to work on it from home, and Travis tried to build it, and I broke the build! Apologies :)

Would anyone object to Travis only building master for now?

from hiera-eyaml.

sihil avatar sihil commented on August 16, 2024

I actually changed the image in the README.md to only look at master, which I think it enough. Weirdly changing the readme broke one of the three builds :( Looks like we have an intermittent build issue which makes me sad. Hopefully we can just increase a timeout somewhere.

from hiera-eyaml.

sihil avatar sihil commented on August 16, 2024

Hey @TomPoulton, do you have time to look at merging #55 and cutting a 1.3.8 gem? I'm going to cut 0.3 of hiera-eyaml-gpg, but I've included references to the new RecoverableError in it which needs the changes in #55.

Also - I think you mentioned that you were going to tag the repo each time you did a release. I can't see them on the repo which might be because you haven't pushed them - you need to do a git push --tags to push any tags upstream.

Have a good weekend everyone.

from hiera-eyaml.

TomPoulton avatar TomPoulton commented on August 16, 2024

I'm actually out of town this weekend but I can push a new gem up first thing on Monday (US time)

And thanks for the heads up for the tags, I just assumed the tags would get pushed with the commits, I'll do that Monday too!

Feel free to merge your changes into master if the tests look good, and then at least Travis will be happy and the build ready to go!

from hiera-eyaml.

TomPoulton avatar TomPoulton commented on August 16, 2024

v1.3.8 is now pushed

(and hopefully the tags :))

from hiera-eyaml.

sihil avatar sihil commented on August 16, 2024

Great - thanks @TomPoulton - I can confirm that the tags are now visible :)

from hiera-eyaml.

TomPoulton avatar TomPoulton commented on August 16, 2024

v2.0.0 published!!! Awesome!! Thanks once again to @gtmtech and @sihil for writing and testing this

bring on v3 ;)

from hiera-eyaml.

hopperd avatar hopperd commented on August 16, 2024

This is a nice alternative to hiera-gpg, one addition that would make it really solid is if it supported JSON as well. Any chance on getting something like that supported?

from hiera-eyaml.

sihil avatar sihil commented on August 16, 2024

Thanks @Split3.

Do you mean json files or json values? At the end of the day, JSON is a subset of YAML - so this should be pretty easy to implement. If you clarify what your requirements are then we'll have a think about it. Alternately, you are always welcome to make a pull request :)

from hiera-eyaml.

hopperd avatar hopperd commented on August 16, 2024

More specifically json values so you could have a configuration file mynode.json

{
  "secure-property" : "ENC[PKCS7,Y22exl+OvjDe+drmik2XEeD3VQtl1uZJXFFF2NnrMXDWx0csyqLB/2NOWefv
    NBTZfOlPvMlAesyr4bUY4I5XeVbVk38XKxeriH69EFAD4CahIZlC8lkE/uDh
    jJGQfh052eonkungHIcuGKY/5sEbbZl/qufjAtp/ufor15VBJtsXt17tXP4y
    l5ZP119Fwq8xiREGOL0lVvFYJz2hZc1ppPCNG5lwuLnTekXN/OazNYpf4CMd
    /HjZFXwcXRtTlzewJLc+/gox2IfByQRhsI/AgogRfYQKocZgFb/DOZoXR7wm
    IZGeunzwhqfmEtGiqpvJJQ5wVRdzJVpTnANBA5qxeA==]"
}

from hiera-eyaml.

TomPoulton avatar TomPoulton commented on August 16, 2024

Hi @Split3, @clarenceb, @devin-c, @sammcj, @larryfast, @andrewh, @adamgraves85, @reinoud, and anyone else I may have missed.

I'm aware that there are a number of issues outstanding including pull requests with new fixes and features! Thank you all for the feedback and work you've put into this, I've been keeping an eye on project so don't feel like we're ignoring you, @sihil and I are emailing at the moment to work out some time to put into this so we'll respond to each issue soon!

Sorry it's taken so long, I just wanted to let you guys know that we haven't abandoned you and we value the effort you've been putting in! I've just had a 12 hour day so I'm going to have a beer but expect some more follow up soon (or some really nasty commits if I keep drinking ;))

from hiera-eyaml.

sammcj avatar sammcj commented on August 16, 2024

Thanks @TomPoulton , Enjoy your beer!

from hiera-eyaml.

sihil avatar sihil commented on August 16, 2024

Hey folks,

I've spent a large portion of my day working through all the open pull requests and issues. It would be great if the open pull requests could be reviewed and merged. #70, #72, #76 #77 and #78 are in my opinion ready to go, but could do with a second pair of eyes.

If one of @gtmtech or @TomPoulton could review and merge these I think it would be a good aim to get a new gem out by Thursday, which gives one day before the weekend to cut another one if, for whatever reason, it turns out to be a dud.

We should probably create some release notes or at least add a list of fixes to the top of the README with relevant shout outs for those who raised / contributed to fixing the issues.

That's largely the list of people you mentioned in your last comment @TomPoulton with links and brief descriptions to each pull requests I guess?

Cheers guys,
Simon

PS. I'm on holiday from Saturday though to the 18th.

from hiera-eyaml.

TomPoulton avatar TomPoulton commented on August 16, 2024

Hi @sihil, my inbox is now full of updates from you so good job on all of that :)

I'll take a peak at some of those pull requests soon unless @gtmtech beats me to it! And yes I agree, release notes would be extremely useful and people should definitely be credited for their contributions

I'll report back soon!

from hiera-eyaml.

TomPoulton avatar TomPoulton commented on August 16, 2024

hiera-eyaml v2.0.1 is now on rubygems and contains all 5 pull requests that @sihil mentioned above!

Thanks to EVERYONE for your work, hopefully we (read "I") will be quicker with the pull requests in the future. Release notes to come soon!

There is a caveat for #76 but it might turn out to be nothing, and we can fix it later if needs be

from hiera-eyaml.

sihil avatar sihil commented on August 16, 2024

Hey @TomPoulton,

Hope you are well.

Can you merge #87 and cut a new gem version? It's causing some people quite a lot of pain. It's a packaging change so doesn't impact functionality. The build didn't pass, but that was a problem with TravisCI which I've fixed in master.

Happy to do releases going forward if you are willing to add me as a gem owner for hiera-eyaml (via gem owner).

Cheers mate,
Simon

from hiera-eyaml.

TomPoulton avatar TomPoulton commented on August 16, 2024

#87 merged, and v2.0.2 pushed

@sihil thanks for putting so much time into this, I'm moving to the US at the moment, as well as all the usual work stuff (although I'm working on something that we might open source that I think you might like) so I haven't got a lot of free time, I'm sure it'll get better soon, although I remember telling myself that a few months ago ;) In the meantime I'll definitely add you as an owner, let me know what email you gems account is linked to

Tom

from hiera-eyaml.

sihil avatar sihil commented on August 16, 2024

Hi @TomPoulton - I sent you an e-mail with the address I use for rubygems.

I thought you were already in the US for some reason? A mistaken assumption by the sounds of things - where are you moving from.

Also if you or @gtmtech have time to review #90 that would be useful - just a couple of minor improvements I've been meaning to do for a while now.

Simon

from hiera-eyaml.

sihil avatar sihil commented on August 16, 2024

OK - I'm hoping to cut a 2.0.4 gem very soon (this week if at all possible). There are quite a few changes, so I'm going to make a note of them here and I propose we introduce a CHANGES.md document listing them.

I've included #118, provided it's ready to ship.

These are the changes since the 2.0.3 cut:

  • #118 - Some initial support for spaces in filenames (primarily targeted at windows platforms) (@elyscape)
  • #114 - Add new config file resolution so that a system wide /etc/eyaml/config.yaml is processed first (@gtmtech)
  • #112 - Improve debugging options and colorise output (@gtmtech)
  • #102 - Extension of temp files should be yaml to help editors provide syntax highlighting (@ColinHebert)
  • #90, #121, #122 - Add preamble in edit mode to make it easier to remember how to edit (@sihil)
  • #96, #111, #116 - Various updates to docs

from hiera-eyaml.

TomPoulton avatar TomPoulton commented on August 16, 2024

Lots of changes, thanks everyone for all the work!! changes.md is definitely a good idea.

Let me know when we're ready to cut a new gem, although @sihil I think you've got all the necessary permissions if you don't want to wait for my timezone to wake up

from hiera-eyaml.

gtmtech avatar gtmtech commented on August 16, 2024

Although we have lots of issues to fix, my vote is for a new gem to be cut an published ASAP please @TomPoulton , @sihil

from hiera-eyaml.

gtmtech avatar gtmtech commented on August 16, 2024

Bump @TomPoulton @sihil . Can you give me access to push new gems, if you guys are too busy?

Thanks

from hiera-eyaml.

sihil avatar sihil commented on August 16, 2024

I'm not sure I can (give you permission). I meant to cut one over the weekend, but didn't get around to it (I'm afraid Elite:Dangerous absorbed me). I'll try and get to it this evening if I don't get home too late.

from hiera-eyaml.

sihil avatar sihil commented on August 16, 2024

v2.0.4 published

from hiera-eyaml.

gtmtech avatar gtmtech commented on August 16, 2024

Great stuff 👍 - i've got a whole heap of stuff to push soon, i think we should sort out the puppet forge stuff next.

from hiera-eyaml.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.