Comments (4)
I've done some digging when @alexjfisher mentioned it on IRC.
https://github.com/puppetlabs/beaker/blob/master/lib/beaker/host.rb#L390-L392 does a glob of all the potential directories and rejects anything that matches the ignore_re.
The issue with this is that the Regex is not specific enough and matches anything that is in the path.
So if you have a path called /foo/bar/spec/something
it gets ignored because it has spec
in the path name.
We should only process the ignoring of directories in the source dir it self.
A potential fix is to do f.gsub(source, '') =~ ignore_re
at https://github.com/puppetlabs/beaker/blob/master/lib/beaker/host.rb#L391
which strips out the source path so we only evaluate the directories that are in the source path.
@anodelman any opinions on this?
from beaker.
I think that our scp ignore is pretty much a mess and I'm going to be reviewing it this week. The difficulty here is that some code depends upon our flexible attitude towards what is a match, yet, in this case, it is stabbing us in the back.
What really needs to happen here is better doc-ing that makes it clear what ignore does/doesn't do and then stick to i.
from beaker.
A fix for this is actually included in #730 - to only match against subdirs of the provided dir.
from beaker.
PR merged.
from beaker.
Related Issues (20)
- The beaker reboot needs to cross minute boundaries based on the method used HOT 6
- retry_on says that it can take an Array of hosts, but it will fail if one is passed
- beaker is failing to run acceptance tests on existing node HOT 2
- Rsync may not be able to use a provided password for the SSH connection HOT 2
- (BKR-1690) Rm -rf not working when path has spaces and logging on localhost
- (BKR-1675) Update net-scp to version 3.0.0 HOT 1
- Add support for opensuse? HOT 3
- The get_ip method should match on any vagrant-backed hypervisor
- ssh_config file not used by default HOT 3
- EL 9 error - /sbin/service: No such file or directory
- Failed to exec 'vagrant up' (rbenv, ruby 2.7.6, bundler 2.3.19, virtualbox) HOT 11
- Ruby 3.1/Psych 4 compatibility issues HOT 3
- 4.39.0 breaks beaker-puppet tests HOT 1
- Consider setting defaults to systemctl/systemd commands
- Minitar v1 has been released
- Support installing modules from git branches HOT 4
- having error finding my class using beaker HOT 1
- how can i test hiera roles using beaker? HOT 2
- Better Openstack IP address assignment HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from beaker.