Code Monkey home page Code Monkey logo

Comments (3)

bnfinet avatar bnfinet commented on May 21, 2024

I think what's happening is that err is never set and is default nil.

The whitelist is present, so it is tested but the user is not found in the whitelist. The err should be set after not finding the user in the whilte list, at the end of this block (but it is not):
https://github.com/vouch/vouch-proxy/blame/a83233064598b1a62ed8aff1ae07caa771f1f10c/handlers/handlers.go#L332

The error (which is nil) is logged and rendered here..
https://github.com/vouch/vouch-proxy/blame/a83233064598b1a62ed8aff1ae07caa771f1f10c/handlers/handlers.go#L392-L396

from vouch-proxy.

cyounkins avatar cyounkins commented on May 21, 2024

Screen Shot 2019-03-19 at 7 33 50 PM

from vouch-proxy.

bnfinet avatar bnfinet commented on May 21, 2024

suweet!

Hey @cyounkins thanks for all your thoughts and contributions. I'm playing a bit of catch-up after being gone for a few weeks on a trip. I may not get this merged for a day or two here but I very much appreciate you poking your nose around and offering your code and thoughts.

from vouch-proxy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.