🐛 Somehow, the second weighted path is picked. <div class="highlight highlight-so

The issue is at <div class="Box-header f6"

Oh yeah, I remember now. <a class="issue-link js-issue-link" data-error-text="Failed t

:bug: the second weighted path is picked about zlocation HOT 6 OPEN

zhaocai commented on August 23, 2024 2

:bug: the second weighted path is picked

from zlocation.

Comments (6)

vors commented on August 23, 2024

Hmm, I think there could be some logic about preferring the (apparently case-sensitive) prefixes... cannot quickly find it.

from zlocation.

Snaptags commented on August 23, 2024

I have similar cases and my guess is that matches at the beginning of the folder name are being preferred, regardless of the entry's weight:
107 C:\Users\Zhao\Documents\WindowsPowerShell\Modules\oh-my-posh
65 C:\Users\Zhao\Documents\WindowsPowerShell\Modules\posh-git

That is of course a valid metric, BUT weight should overrule the "beginning of name" rule.

from zlocation.

theaquamarine commented on August 23, 2024

The issue is at

ZLocation/ZLocation/ZLocation.Search.psm1

Lines 18 to 30 in 29cb9e6

    
           # we should prefer paths that start with the query over paths with bigger weight 
        
           # that don't. 
        
           # i.e. if we have 
        
           # /foo = 1.0 
        
           # /afoo = 2.0 
        
           # and query is "fo", we should prefer /foo 
        
           $res = $hash.GetEnumerator() | % { 
        
               New-Object -TypeName PSCustomObject -Property @{ 
        
                   Name=$_.Name 
        
                   Value=$_.Value 
        
                   Starts=[int](Start-WithPrefix -Path $_.Name -lowerPrefix $lowerPrefix) 
        
               } 
        
           } | Sort-Object -Property Starts, Value -Descending

, the results are sorted by whether or not they start with the prefix, then by their value. Changing

ZLocation/ZLocation/ZLocation.Search.psm1

Line 30 in 29cb9e6

} | Sort-Object -Property Starts, Value -Descending

to Sort-Object -Property Value, Starts -Descending should resolve this, as results will then be sorted by value first, only using the prefix if two have the same value.

from zlocation.

vors commented on August 23, 2024

Oh yeah, I remember now. #26 where it started. I don't know what's really the right answer here - should the tool try to be smarter or should it try to be dumber but more predictable.

from zlocation.

eamodio commented on August 23, 2024

I have been seeing the same issue and its been driving me nuts 😄

from zlocation.

deviousasti commented on August 23, 2024

Any workarounds for this?

from zlocation.

Recommend Projects

:bug: the second weighted path is picked about zlocation HOT 6 OPEN

Comments (6)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	# we should prefer paths that start with the query over paths with bigger weight
	# that don't.
	# i.e. if we have
	# /foo = 1.0
	# /afoo = 2.0
	# and query is "fo", we should prefer /foo
	$res = $hash.GetEnumerator() \| % {
	New-Object -TypeName PSCustomObject -Property @{
	Name=$_.Name
	Value=$_.Value
	Starts=[int](Start-WithPrefix -Path $_.Name -lowerPrefix $lowerPrefix)
	}
	} \| Sort-Object -Property Starts, Value -Descending