Path info in default z output is clipped about zlocation HOT 10 CLOSED

Totally! Would you like to send a PR? :)

from zlocation.

I'll take a look at it tonight.

from zlocation.

I think you'll have to set a defaultdisplaypropertyset on the returned values.

https://docs.microsoft.com/en-us/dotnet/api/system.management.automation.runspaces.typedata.defaultdisplaypropertyset?view=powershellsdk-1.1.0

It might be tricky because it's technically a single Hashtable value being returned, which I think is being enumerated as a bunch of DictionaryEntrys. So they're controlling the rendering. You might need to replace the returned value with some sort of custom collection.

from zlocation.

Yup, I was initially trying to stick with the hashtable and give the "DictionaryEntry" objects a new type name in their typenames collection. But GetEnumerator() generates new DictionaryEntry objects. :-(

from zlocation.

from zlocation.

Class syntax would limit this module to v5 and higher. I don't think that is ideal but it's up to @vors. Maybe we could return a PSCustomObject but maintain a module level, private variable that is the hashtable for quick lookup of the weight from the path (key). Also, to work better on Linux the hashtable/dictionary should be case-sensitive.

from zlocation.

from zlocation.

I opened #64 for the 5.0 question, I'm a little bit on the fence about it.
I think this works ( 🤷‍♀️ ):

... .GetEnumerator() | Select-Object -Property Name, Value

from zlocation.

If we only intend to change the behavior of Invoke-Location (and z - alias to this function) that should work. Although it would need to be something like this:

    if ($null -eq $match) {
        Get-ZLocation |
            ForEach-Object GetEnumerator |
            Select-Object @{Name='Weight';Expression={$_.Value}},@{Name='Path';Expression={$_.Name}}
        return
    }

Outputs:

Weight Path
------ ----
     3 C:\Users\Keith\GitHub\rkeithhill\ZLocation
     1 C:\Users\Keith
     6 C:\Users\Keith\GitHub\rkeithhill\ZLocation\ZLocation

Although that outputs a series of DictionaryEntry objects with Weight/Path properties tacked on. That feels a bit odd. The output of Invoke-Location is not internally used so we could probably get away with changing the output from hashtable to something else. I think a set of PSCustomObjects would probably be better. External users can still access the hashtable by calling Get-ZLocation. Thoughts? If you agree in principle I submit a PR for this.

from zlocation.

OK, this is the [PSCustomObject] version:

    if ($null -eq $match) {
        Get-ZLocation |
            ForEach-Object {$_.GetEnumerator()} |
            ForEach-Object {[PSCustomObject]@{Weight = $_.Value; Path = $_.Name}}
        return
    }

Now, need to figure out how far back [PSCustomObject] goes. I think it goes back to v3. If so, we'd be good.

from zlocation.