Code Monkey home page Code Monkey logo

Comments (4)

Siilwyn avatar Siilwyn commented on July 18, 2024

Hi @JanStevens thank you for your contribution, we'll get back to you :)
Hiding is already a feature right? Do you mean not rendering the title too?

@velomovies thoughts on rendering the field as disabled?
Can imagine not rendering the title could be nice but also could lead to confusion where data is coming from?

from datocms-plugin-computed-fields.

JanStevens avatar JanStevens commented on July 18, 2024

@Siilwyn I indeed mean not rendering anything at all (see related issue: #19 (comment))

At least we should render the field disabled to clearly indicated to content editors this is an auto generated field

from datocms-plugin-computed-fields.

velomovies avatar velomovies commented on July 18, 2024

Hi @JanStevens,

For hiding the field we already returned nothing in the previous version. I've changed that to returning null instead of a Fragment.

In your example you use the hideField function from Dato next to returning null. That works great in your example, but not in this case. The hideField function will not render the form input, and makes it so the plugin doesn't rerender when something changes in the other fields. Therefore the value of the computed field will not update automatically when you change other fields in the model. The automatic update is something we very heavily rely on and don't want to break when hiding a field.

Showing the field as disabled is a great addition and will be implemented when we update the plugin.

from datocms-plugin-computed-fields.

JanStevens avatar JanStevens commented on July 18, 2024

Allright that sounds great!

from datocms-plugin-computed-fields.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.