Improve error format consistency about vonage-node-sdk HOT 8 CLOSED

Thanks for this @soullivaneuh - I will take a look at this soon and let you know what I can figure out. I'm currently working through some old issues and catching up with the status of the SDK. Thanks again!

from vonage-node-sdk.

@cbetta If you update to V3, we are throwing errors as we have migrated to using promises. This should no longer be an issue for you.

from vonage-node-sdk.

@cbetta better late than never ;)

from vonage-node-sdk.

@leggetter can we close this now, based on the 2.0 release?

from vonage-node-sdk.

@cbetta I thought we could assess this as part of Nexmo/nexmo-cli#123

Based on the above:

The error object in a callback, with a message attributes

If message is present on the body response it will be available via error.body.message. But not across all APIs.

The error object in a callback, with a error-code and error-code-label attribute

Available via error.body['error-code'] etc. But I'd want to check to see what happens if we get a 2xx response. It may be that we don't make a callback with an error.

The response object in a callback, with a status attribute with a value of 0

I don't think we expose the response object. We just expose the success result.

from vonage-node-sdk.

@leggetter ok, I will evaluate!

from vonage-node-sdk.

This one is quite crazy IMO. If I follow the TS API you made, I should implement the verify API that way:

nexmo.verify.request({
  number: phoneNumber,
  brand: 'Company',
  code_length: '4'
}, (err: VerifyError, data: RequestResponse) => {
  if (err) {
    console.log('error:', err);
    throw new Unavailable('test', err);
  }

  console.log('result:', data)
});

Here VerifyError contrains the status and the error_text fields.

But If I try this with bad credentials for example, I have the error... on the data object. 🤔

To me it's a bug as this does not respect the typescript interface.

Am I right?

from vonage-node-sdk.

Tnx for the update after 6 years 😂

from vonage-node-sdk.