Data Attributes about method HOT 8 CLOSED

I thought htmlMin took care of the angular directives but looking in the dist folder I don't see it doing what I thought it did. @jedmao did you consider this plugin: https://www.npmjs.org/package/grunt-html-angular-validate ? Here is what caught my eye as better than the plugin you suggested:

• Support for AngularJS attributes and tags (both from AngularJS and custom created)
• Support for templated/fragmented HTML files

Out of the box it lets you validate with the W3C online validator tool. Which tool do we use for this currently? If we use it alot, we can always host the validator for ourselves. The value in using a tool we can tune to our product is that it will catch the specs as W3C interprets them and if you type data-ng-rrepeat="", the validator will catch it for us.

from method.

@hippee-lee I think you're right about htmlmin, but I don't see it working either and the documentation is lacking there.

The tool you mention looks nice, but it doesn't address this particular issue. Yes, it will validate, but it won't actually change the HTML. The tool I'm calling out will add the data- prefix to ng- attributes.

We should probably use both!

from method.

BTW, we were previously restricting all directives to be attributes so they would validate. Custom tags don't validate yet with HTML5.

I've seen a number of commits to refactor2 that introduce ng- attributes w/o the data- prefix. I'm just worried we'll have to filter through those validation errors. It's just noise.

from method.

Given that htmllmin isn't doing what I thought it was I'll audit the code base and address it with manual changes for now, shouldn't take to long.

Do you know if angular-html5 can be configured for our custom directive convention - vn-blah? Also, did you prefix your directives with data- when you named them in JavaScript?

from method.

@hippee-lee no, you don't need, nor is there a way to add a data- prefix to the JavaScript directive. Technically, they can initialize your directive with or without the data- prefix.

I'm with you on angular-html5 adding a feature for custom directives. That would be great, but from the documentation I've read, they only do, very simply, ng- attributes.

You might want to open up an issue on the project and see if the idea can get any traction? It's a good idea!

from method.

Actually it does, search for customPrefixes.
Do we know if this works with Grunt or, would we need to consider changing to Gulp? They have a link for Usage in build tools but there are ??'s after Grunt.

from method.

Changing to Gulp would be a huge undertaking at this point. 'Looks like there's a generator-gulp-angular though. When the time comes...

I guess we can't use this package w/o writing a Grunt plugin for now. It's not hard to write a Grunt plugin, but I'm not volunteering.

from method.

Closing this issue for now, but maybe we want to reopen it at some point.

from method.