Code Monkey home page Code Monkey logo

Comments (10)

Monokaix avatar Monokaix commented on August 27, 2024

Glad to receive your feedback! Volcano uses a standard serviceAccount & RBAC rule to grant pod permissions, and seems that k8s has some measures to avoid serviceaccount permission issue like https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/#serviceaccount-token-volume-projection, is this can satisfy your need?

from volcano.

HouqiyuA avatar HouqiyuA commented on August 27, 2024

from volcano.

Monokaix avatar Monokaix commented on August 27, 2024

I found a ClusterRole named "Volcanic-controllers" found in the volcano project code, which has the list secrets permission. Is granting clusterRole list secrets permission necessary in this project? Marty Mcfly @.> 于2024年4月29日周一 10:43写道:

Glad to receive your feedback! Volcano uses a standard serviceAccount & RBAC rule to grant pod permissions, and seems that k8s has some measures to avoid serviceaccount permission issue like https://kubernetes.io/docs/tasks/configure-pod-container/configure-service-account/#serviceaccount-token-volume-projection, is this can satisfy your need? — Reply to this email directly, view it on GitHub <#3446 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBBY3LTWUNUPSTSLULLRGO3Y7WXTNAVCNFSM6AAAAABG4Z6BTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBRG44TQNRTHE . You are receiving this because you authored the thread.Message ID: @.
>

Seems that volcano controller only used GET and CREATE verbs currently: )

from volcano.

Monokaix avatar Monokaix commented on August 27, 2024

Maybe we can remove list permission of volcano controller.

from volcano.

Monokaix avatar Monokaix commented on August 27, 2024

/good-first-issue

from volcano.

volcano-sh-bot avatar volcano-sh-bot commented on August 27, 2024

@Monokaix:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from volcano.

HouqiyuA avatar HouqiyuA commented on August 27, 2024

from volcano.

Monokaix avatar Monokaix commented on August 27, 2024

fixed by #3449

from volcano.

Monokaix avatar Monokaix commented on August 27, 2024

/close

from volcano.

volcano-sh-bot avatar volcano-sh-bot commented on August 27, 2024

@Monokaix: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

from volcano.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.