Comments (8)
OPINION=NO:YES:YES
- Do we need a conversion tool?
- NO: *.conf file is small enough
- Should support for old-format configs be dropped?
- YES: drop old-format configs after 1.0
- Should any of this happen before 1.0 is officially released?
- YES: use 1.0 as transition release
- keep old *.conf parser in 1.0
- provide new *.yaml parser in 1.0
- startup logic for 1.0 : try *.conf first, fall back to *.yaml
from thinkfan.
Definitely like this idea! Really getting into tweaking my own thinkpad t430s setup as of today, and YAML would be great for the conf file. Especially with the more complex per-sensor setups and additional features added from future development.
from thinkfan.
ok, this is what a YAML config could look like:
sensors:
- hwmon: /sys/devices/platform/coretemp.0
temps: [1, 3]
- tp_thermal: /proc/acpi/ibm/thermal
pwm_fan: /sys/class/hwmon....
#tp_fan: /proc/acpi/ibm/fan
levels:
- speed: 0
upper_limit: [50, 50, 50]
- speed: 2
lower_limit: [45, 45, 45]
upper_limit: [60, 60, 60]
# ...
The way the dashes are use does not look very intuitive to me... better ideas?
from thinkfan.
Is this why I get this error in 1.0_beta2 (AUR)?
ERROR: /etc/thinkfan.conf:46: Invalid syntax:
(0, 0, 42)
^
from thinkfan.
@hungryseashell please report a separate issue about this. Don't forget to mention the exact version you're using (git/beta?) and your distribution. The complete config file would be helpful as well ;-)
from thinkfan.
I guess the config file format doesnt matter much but what would make it much easier for the most people is a gui to change the basic options like tpfanco or fancontrol-gui
from thinkfan.
@sixsixfive Originally I deliberately chose not to have a GUI because I wanted to keep things simple from a technical perspective. However I do see that it would help a lot, which is in fact another reason to switch to YAML, because with a GUI we need to write the config, too, and YAML simplifies this a lot.
from thinkfan.
YAML config is merged into master. Closing this so new issues are reported individually.
from thinkfan.
Related Issues (20)
- temperature input value of feature 'temp2' of chip 'thinkpad-isa-0000' is unavailable
- Failing to load thinkfan on startup HOT 1
- can't start thinkfan.service
- Support globs in the `temp1_input` path in the config HOT 1
- Freeze on Thinkpad P14s Gen3 AMD Machine Type 21J5 HOT 30
- "Invalid sensor entry" on "chip" keyword HOT 15
- [ThinkPad E540] Thinkfan change the levels, but not the actual speed HOT 4
- Allow /sys/devices/platform/thinkpad_hwmon/hwmon/*/temp2_input HOT 1
- ERROR: Unhandled thinkfan::Bug: Segmentation fault.. errno = No such file or directory.
- Arch Linux: error while loading shared libraries after yaml-cpp 0.8.0 upgrade HOT 5
- setting RPM that corresponds to the speed levels manually HOT 2
- Could not find a hwmon with this name: thinkpad HOT 1
- ERROR: Unhandled std::bad_optional_access: bad optional access.
- Failed to initialize NVML driver. If gpu is disabled HOT 1
- Thinkfan does not resume after wake from suspend HOT 3
- thinkfan.service won't start HOT 1
- small issue: no thinkfan pkg for debian 11 bullseye?
- Crashed after resume from system sleep
- hwmon model is an invalid keyword
- Thinkfan goes into `device` folder instead of the `hwmonX` folde HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from thinkfan.