Config format & parser sucks about thinkfan HOT 8 CLOSED

OPINION=NO:YES:YES

1. Do we need a conversion tool?

• NO: *.conf file is small enough

2. Should support for old-format configs be dropped?

• YES: drop old-format configs after 1.0

3. Should any of this happen before 1.0 is officially released?

• YES: use 1.0 as transition release
• keep old *.conf parser in 1.0
• provide new *.yaml parser in 1.0
• startup logic for 1.0 : try *.conf first, fall back to *.yaml

from thinkfan.

Definitely like this idea! Really getting into tweaking my own thinkpad t430s setup as of today, and YAML would be great for the conf file. Especially with the more complex per-sensor setups and additional features added from future development.

from thinkfan.

ok, this is what a YAML config could look like:

sensors:
  - hwmon: /sys/devices/platform/coretemp.0
    temps: [1, 3]

  - tp_thermal: /proc/acpi/ibm/thermal

pwm_fan: /sys/class/hwmon....
#tp_fan: /proc/acpi/ibm/fan

levels:
  - speed: 0
    upper_limit: [50, 50, 50]

  - speed: 2
    lower_limit: [45, 45, 45]
    upper_limit: [60, 60, 60]

  # ...

The way the dashes are use does not look very intuitive to me... better ideas?

from thinkfan.

Is this why I get this error in 1.0_beta2 (AUR)?

ERROR: /etc/thinkfan.conf:46: Invalid syntax:
                                   (0,        0,        42)
                                    ^

from thinkfan.

@hungryseashell please report a separate issue about this. Don't forget to mention the exact version you're using (git/beta?) and your distribution. The complete config file would be helpful as well ;-)

from thinkfan.

I guess the config file format doesnt matter much but what would make it much easier for the most people is a gui to change the basic options like tpfanco or fancontrol-gui

from thinkfan.

@sixsixfive Originally I deliberately chose not to have a GUI because I wanted to keep things simple from a technical perspective. However I do see that it would help a lot, which is in fact another reason to switch to YAML, because with a GUI we need to write the config, too, and YAML simplifies this a lot.

from thinkfan.

YAML config is merged into master. Closing this so new issues are reported individually.

from thinkfan.