Add rules in bulk about valitron HOT 7 CLOSED

I like the second syntax you presented - to me it says "rule" => "array of params", which is more in-line with how the rule method works internally, so it works more naturally. Submit a PR that makes it work with tests, and I will happily accept and merge it. Thanks for the contribution!

from valitron.

Thanks. Any suggestion on how to properly test this?

One thought I had was to create two Validator objects and add the exact same rules and data: one object uses rule(), the other uses rules(). Then call validate() on both and make sure they match.

I'm open to suggestions.

from valitron.

Maybe also compare the error output too to make sure the same things failed in the same way on both sides? Testing for true is bad since it will return true on an empty set of rules.

from valitron.

Yeah basically you just want to make sure it still validates correctly - you shouldn't be concerned with how the Validator stores it internally (the protected $_validators property). You can also check the $v->errors() array to check for specific failures on expected fields.

from valitron.

Perfect. Will send the PR as soon as it's ready.

from valitron.

Sent a PR for review (not merge). It created a new issue.

from valitron.

This has been added in v1.0.3 (SHA1: c049a8f)

from valitron.