Code Monkey home page Code Monkey logo

Comments (8)

esebastian avatar esebastian commented on August 17, 2024 1

Hey @andoniaf, would you feel confortable throwing a docker-compose.yml in to the mix to make it simpler for people to run the site in development mode (so there's no need to worry about the API or the DB)?

from vlctechhub-site.

esebastian avatar esebastian commented on August 17, 2024 1

@andoniaf I've uploaded to Docker Hub the API image built from the current Docker config in its repo VLCTechHub/VLCTechHub-api.

I'm sure it could be optimized, so feel free to propose there any change you fancy.

from vlctechhub-site.

andoniaf avatar andoniaf commented on August 17, 2024

I've created this #75 PR to add it.

Tomorrow I will add some info to the README and the "Construyendo el sitio web" section in CONTRIBUTING.md and remove the "draft" status form the PR.

from vlctechhub-site.

andoniaf avatar andoniaf commented on August 17, 2024

I'm not sure about where I should add the info about how to run the site with docker. Inside "# 🚀 Construyendo el sitio web" or creating a section called "# 🚀 Construyendo el sitio web con Docker"?

from vlctechhub-site.

hell03610 avatar hell03610 commented on August 17, 2024

Thanks!! Could you add a separated section in the contributing? If you write it in English that would be perfect, I'm translating the .md files in this repo so it will be easier to merge then.

from vlctechhub-site.

andoniaf avatar andoniaf commented on August 17, 2024

Thanks!! Could you add a separated section in the contributing? If you write it in English that would be perfect, I'm translating the .md files in this repo so it will be easier to merge then.

@hell03610 , okey, I will add it as a separated section in English 👍

Hey @andoniaf, would you feel confortable throwing a docker-compose.yml in to the mix to make it simpler for people to run the site in development mode (so there's no need to worry about the API or the DB)?

Hey @esebastian , I could do it, but how we would like to handle it? I mean, the API is in another repo and as far as I know the API image is not uploaded to any docker registry right? I can create a docker-compose explaining that you need to edit it and add your own path to the API folder. Is that okey?

from vlctechhub-site.

andoniaf avatar andoniaf commented on August 17, 2024

@esebastian I'm working on the docker-compose, is there a reason to not copy the Rakefile in the VLCTechHub/VLCTechHub-api image? If the way to run the api container is with bundle exec rake up, to use it "outside" the api repo we need to copy the Rakefile in the image too right?

If not we can explain in the docs that you need the api repo in local too, and in the docker-compose do something like this with the source:

  api:
    image: vlctechhub/api:latest
    volumes:
      - type: bind
        source: ../VLCTechHub-api
        target: /app
        consistency: delegated

from vlctechhub-site.

esebastian avatar esebastian commented on August 17, 2024

The rake up task is designed to start the server only in the development environment, and the rest of the Rake tasks are not really needed on a production Docker image of the API (apart from the Twitter related ones, but those are still WIP and do not have any impact here).

For the purpose of this issue we shouldn't neither need the API source code nor having the API running in development mode, so it would be enough to use the published production image vlctechhub/api:latest without neither any volume mapping nor a custom command override.

Nevertheless, we'll need to provide a value for database connection URL through the MONGODB_URI environment variable and we would also need to ensure that the database to use has some useful data, so we'll need to devise a procedure for that, either by seeding the data on the container initialization, by using a database image already containing the data or by any other means.

Does it look good to you or do you think we're missing something?

from vlctechhub-site.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.