Code Monkey home page Code Monkey logo

Comments (4)

phorward avatar phorward commented on June 17, 2024

Hello,

according to https://github.com/viur-framework/vi/blob/master/network.py#L104, retry is only done on the following error codes: 0, -1, 500 and 502.

0, -1 and 502 occur on network connectiviy failures. The only option which might corrupt data is 500, when something on the server stored and crashed afterwards. We could change this line to read for 0, -1 and 502 only. Any other status codes (non 200) are handled properly.

from viur-vi.

tsteinruecken avatar tsteinruecken commented on June 17, 2024

Please see https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/urswDsm6Pe0 .
You must not retry Post-Requests unless you have proof the Server didn't receive or did not process the request. As we don't use the Bad Gateway code our self this may only be raised from the appengine front end servers or some 3rd party proxy in the middle, so 502 should be off that list as well. Not sure about 0 and -1 (haven't checked how browser handle these), but again: if you can't be sure the request did not process at all: don't retry.

from viur-vi.

phorward avatar phorward commented on June 17, 2024

Ok, in this case we do it on 0 and -1 only.

from viur-vi.

phorward avatar phorward commented on June 17, 2024

fixed with b6922f8

from viur-vi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.