Code Monkey home page Code Monkey logo

Comments (20)

csr632 avatar csr632 commented on May 24, 2024 4

@csr632 Is it updated?

Sorry for the delay! I haven't implement it because of lack of time. But since somebody have request for it, I will put more priority on it. I will implement this in a week.

from vite-plugin-react-pages.

csr632 avatar csr632 commented on May 24, 2024 2

@csr632 How long will it take for React Router 6 + React 18 to release a version,

I am working on a update that:

  • upgrade react to 18.x (will fix this issue)
  • upgrade react-router to 6.x (will fix #72)
  • upgrade mdx to 2.x (will fix #69)

And it will be a new major version. I will release an alpha version this week.

from vite-plugin-react-pages.

yunsii avatar yunsii commented on May 24, 2024 1

What problem do you encounter with PageStrategy ? It is related to React 18?

No, just react-dom warning in console. Convention over configuration, maybe provide a official PageStrategy auto load page data is better. like: https://d.umijs.org/guide/basic

from vite-plugin-react-pages.

yunsii avatar yunsii commented on May 24, 2024 1

Maybe I can do something for the repo, is there a roadmap?

from vite-plugin-react-pages.

Evansy avatar Evansy commented on May 24, 2024 1

@csr632 Is it updated?

from vite-plugin-react-pages.

csr632 avatar csr632 commented on May 24, 2024

Yes!

from vite-plugin-react-pages.

yunsii avatar yunsii commented on May 24, 2024

Is it coming soon? I'm using vite-plugin-react-pages to custom my starter-vite-react-library[WIP], and it's not easy to integrate with PageStrategy as my mind 😂

from vite-plugin-react-pages.

csr632 avatar csr632 commented on May 24, 2024

What problem do you encounter with PageStrategy ? It is related to React 18?
Is this doc helpful to you? https://vitejs.github.io/vite-plugin-react-pages/advanced-fs-routing
(I am also planning to write Chinese translation of document: #74)

from vite-plugin-react-pages.

csr632 avatar csr632 commented on May 24, 2024

Is it coming soon?

I expect one week of work to do the migration (React Router 6 + React 18).

from vite-plugin-react-pages.

csr632 avatar csr632 commented on May 24, 2024

Convention over configuration, maybe provide a official PageStrategy auto load page data is better. like: https://d.umijs.org/guide/basic

Agreed. Currently the default "convention" is only suitable for app. I should provide a PageStrategy that can be reused by library developer. dumi is indeed a great project to learn from.

from vite-plugin-react-pages.

csr632 avatar csr632 commented on May 24, 2024

That would be greate! Contributions are very welcome. You can start with writing (or improve) playground and template to satisfy specific needs of users.
For example, your library template would be a great demo for users that want to create a library. Currently our library template is not very practical because it doesn't include build scripts to build the library (it only have scripts to run and build demo).
The demo document site is also not very practical. We can use vite-pages to build sites that has features like docusaurus.io, d.umijs.org, storybook.js.org. They are greate examples of document sites. We can also bring those feature to improve vite-pages document site.
By doing that, we can know what features are missing and valuable for users, and implement them in the theme-doc or vite-pages-core. Hopefully, you will be familiar with this repo by then, and be able to implement those features!
If you want to start with a concrete feature, you can try to implement docuement search in the theme doc. Anyway, your ideas and discussions about missing feature is already great help for this project!

Building this project have helped me to learn many things like vite, ssr, docusaurus, github ci...... It let me learn by implementing. Hopefully it can help you too.

is there a roadmap?

I use issues to track TODO (clear feature demand) . I have some vague ideas in my mind (such as more powerful demo rendering like storybook.js, better TS interface info extraction), but they are not clearly designed yet.

from vite-plugin-react-pages.

yunsii avatar yunsii commented on May 24, 2024

Great, start with my lib template is good idea, but there is a question, how to integrate with my template, I will improve it continuously. By init script or others?

from vite-plugin-react-pages.

csr632 avatar csr632 commented on May 24, 2024

Great, start with my lib template is good idea, but there is a question, how to integrate with my template, I will improve it continuously. By init script or others?

You can continue improve your template in your repo. And when it is ready, we can add a build script before publishing create-vite-pages ("scripts: {"pull-template-lib": "script to pull template from you repo into this repo..."}") to pull your template into this package.

from vite-plugin-react-pages.

yunsii avatar yunsii commented on May 24, 2024

So where to place pull-template-lib script? I'm not understand.

from vite-plugin-react-pages.

csr632 avatar csr632 commented on May 24, 2024

In the package.json of create-vite-pages:

https://github.com/vitejs/vite-plugin-react-pages/blob/main/packages/create-project/package.json

I will run the script before publishing the package.

from vite-plugin-react-pages.

csr632 avatar csr632 commented on May 24, 2024

I just updated the url in the previous comment. Sorry for the broken url 😂

from vite-plugin-react-pages.

yunsii avatar yunsii commented on May 24, 2024

Got it. I'm working on it now, the aim today is working as my expected routes 😂

from vite-plugin-react-pages.

qiaogaolong avatar qiaogaolong commented on May 24, 2024

@csr632 How long will it take for React Router 6 + React 18 to release a version,

from vite-plugin-react-pages.

qiaogaolong avatar qiaogaolong commented on May 24, 2024

@csr632 Thanks for your hard work,If it is successful, please tell me, I will always pay attention

from vite-plugin-react-pages.

csr632 avatar csr632 commented on May 24, 2024

It's done! Currently it is published in an alpha version. Check it out: #96

from vite-plugin-react-pages.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.