Code Monkey home page Code Monkey logo

Comments (11)

patak-dev avatar patak-dev commented on August 17, 2024 1

I don't know if we can do easily do it at this point, maybe we need support in VitePress for such a feat. The idea of having consistent URLs is to be able to do it at one point.

At least we should add a link that redirects to the home page for the moment. I'll send a PR to Vite and this repo to do that.

from docs-cn.

patak-dev avatar patak-dev commented on August 17, 2024 1

I think that it would be good to have the Languages link for consistency, and you can use '多语言' for it as it is in https://cn.vuejs.org/index.html. At least if I get to some future Spanish docs (my native language, I would like to have the option to switch). The only issue that I see is to keep the list of languages up to date, but a new language is not something that happens all the time.

from docs-cn.

ShenQingchuan avatar ShenQingchuan commented on August 17, 2024 1

Pull Request Merged.

from docs-cn.

ShenQingchuan avatar ShenQingchuan commented on August 17, 2024

OK,switching languages for a certain page sounds great!

Would you like to provide a PR for this repo to implement that ?

The Chinese translation are ready for that.

from docs-cn.

ShenQingchuan avatar ShenQingchuan commented on August 17, 2024

OK, Let's see the PR...

from docs-cn.

ShenQingchuan avatar ShenQingchuan commented on August 17, 2024

It seems like that a dropdown nav link in Vitepress can not be configured to not open a new browser tab, I just tested it locally...

Is it acceptable for now? Maybe we need a new issue for Vitepress to support that configuration.

from docs-cn.

patak-dev avatar patak-dev commented on August 17, 2024

See vitejs/vite#2803, I think there is value in adding this now, and we can later improve it. If you have the same change done for this repo, would you mind committing it yourself?

About the PR to modify the titles, I prefer that the translation team would handle that, as it is more involved than I thought (I think that internal links and main titles should also be replaced). This is the japanase config file: https://github.com/vuejs-jp/vite-docs-ja/blob/main/.vitepress/config.js

I also don't understand if the internal anchors of each page (subtitles) should be in English or in the local language. I think that even if anchors can not be easily swapped, it is better to have them respecting the locale. @kiaking, maybe you have some ideas here.

from docs-cn.

ShenQingchuan avatar ShenQingchuan commented on August 17, 2024

I prefer use the local current language...

The current situation in https://cn.vuejs.org, the Chinese version nav link text is '多语言' rather than 'Languages' ...

if I jumped from Chinese to Japanese, it's another site that can display the nav link's innerText in its own language...

from docs-cn.

ShenQingchuan avatar ShenQingchuan commented on August 17, 2024

By the way... I quite doubt that we really need this... Generally, anyone in the world may start from the English version after he/she searched 'vite'...
All we need is provide a full list of languages as the 'Languages' navlink in English site...

Is there really anyone which is a Chinese/Japanese, but first start from a Français documentation and wanna turn to his/her language site there? 🤣

from docs-cn.

ShenQingchuan avatar ShenQingchuan commented on August 17, 2024

OK,
And one more thing we may discuss about...

In Chinese site, is it necessary to keep the Chinese option in that list ?
For now, there isn't a Chinese('简体中文') option in https://cn.vuejs.org, I would like to be the same.

from docs-cn.

patak-dev avatar patak-dev commented on August 17, 2024

I was following https://vuepress.vuejs.org/, where both options are there. I think that if the number of languages is small, it is better to show all. We should probably rename Language to Translations if not. Once we have a lot of languages, maybe we could migrate to only showing the rest. What do you think?

from docs-cn.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.