Code Monkey home page Code Monkey logo

Comments (6)

vitalik avatar vitalik commented on May 15, 2024 1

url_name argument added to v0.12

from django-ninja.

aprilahijriyan avatar aprilahijriyan commented on May 15, 2024 1

Hi @vitalik, I highly recommend giving the endpoint name based on the view function name. If we declare a name based on the 'url_name' parameter this is very difficult, when we have a lot of endpoints.

from django-ninja.

vitalik avatar vitalik commented on May 15, 2024

Hi @jlward

Yes, makes sense

from django-ninja.

fretchen avatar fretchen commented on May 15, 2024

I would like to reopen it. I did not find any documentation on how to use the reverse function. And in the example of the CRUD I attempted something like:

url = reverse("get_employee", kwargs={"employee_id": 1})

However, I keep getting the error Reverse for 'get_employee' not found. 'currencies' is not a valid view function or pattern name. Things like api:get_employee etc have similiar problems as namespaces seem to be unknown etc...

from django-ninja.

fretchen avatar fretchen commented on May 15, 2024

I wanted to add another problem in adapting the CRUD example. Suppose that you implemented the two following views described, but now with an added url_name:

@api.post("/employees", url_name="create_employee")
def create_employee(request, payload: EmployeeIn):
    employee = Employee.objects.create(**payload.dict())
    return {"id": employee.id}


@api.get("/employees", response=List[EmployeeOut], url_name="list_employees")
def list_employees(request):
    qs = Employee.objects.all()
    return qs

The reverse function does not find the create_employee anymore as it is overwritten by list_employees most likely as they have the same URL.

from django-ninja.

vitalik avatar vitalik commented on May 15, 2024

@fretchen
well that's the way django works
basically each url path has only one name

from django-ninja.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.