Expectation: To be able to run this view async, should this be possible? <p dir="a

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

<a class="user-mention notranslate" data-hovercard-type="user" data-hover

Async reverse relationship about django-ninja HOT 4 OPEN

carvalhochris commented on May 28, 2024

Async reverse relationship

from django-ninja.

Comments (4)

vitalik commented on May 28, 2024

@carvalhochris

try pre fetching also artist_set

Card.objects.prefetch_related("cardhold_set", "artist_set")

from django-ninja.

carvalhochris commented on May 28, 2024

@carvalhochris

try pre fetching also artist_set
Card.objects.prefetch_related("cardhold_set", "artist_set")

Hi @vitalik thanks for your response.

I tried that and get the following:

Traceback (most recent call last):
  File "/Users/christophercarvalho/ninja/env/lib/python3.11/site-packages/ninja/operation.py", line 282, in run
    return self._result_to_response(request, result, temporal_response)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/christophercarvalho/ninja/env/lib/python3.11/site-packages/ninja/operation.py", line 208, in _result_to_response
    validated_object = response_model.model_validate(
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/christophercarvalho/ninja/env/lib/python3.11/site-packages/pydantic/main.py", line 532, in model_validate
    return cls.__pydantic_validator__.validate_python(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
pydantic_core._pydantic_core.ValidationError: 1 validation error for NinjaResponseSchema
response
  Error extracting attribute: SynchronousOnlyOperation: You cannot call this from an async context - use a thread or sync_to_async. [type=get_attribute_error, input_value=<DjangoGetter: <ninja.ope... object at 0x1136c23d0>>, input_type=DjangoGetter]
    For further information visit https://errors.pydantic.dev/2.7/v/get_attribute_error

from django-ninja.

vitalik commented on May 28, 2024

yeah, maybe prefetch_related does not support async yet..

try:

@api.get("/get-cards", response=List[CardOut])
@decorate_view(cache_page(7 * 24 * 60 * 60))
async def list_cards(request):
    queryset = Card.objects.prefetch_related("cardhold_set", "artist_set")
    cards = await sync_to_async(list)(queryset) # force executing db query here by converting to list
    return cards

from django-ninja.

carvalhochris commented on May 28, 2024

yeah, maybe prefetch_related does not support async yet..

try:

@api.get("/get-cards", response=List[CardOut])
@decorate_view(cache_page(7 * 24 * 60 * 60))
async def list_cards(request):
    queryset = Card.objects.prefetch_related("cardhold_set", "artist_set")
    cards = await sync_to_async(list)(queryset) # force executing db query here by converting to list
    return cards