[BUG] Attribute assignment fails if validate_assignment is set to True about django-ninja HOT 2 OPEN

@vitalik I've taken a stab at fixing this, as I'm also blocked on this, PR linked above in history.

from django-ninja.

Peeking in the source code of ninja.schema, it seems the issue would be bypassed by setting extra attributes (so model.foo = bar when foo is not defined in the model) to forbidden in the model_config?

class Schema(BaseModel, metaclass=ResolverMetaclass):
    class Config:
        from_attributes = True  # aka orm_mode

    @model_validator(mode="wrap")
    @classmethod
    def _run_root_validator(
        cls, values: Any, handler: ModelWrapValidatorHandler[S], info: ValidationInfo
    ) -> Any:
        # when extra is "forbid" we need to perform default pydantic validation
        # as DjangoGetter does not act as dict and pydantic will not be able to validate it
        if cls.model_config.get("extra") == "forbid":
            handler(values)

        values = DjangoGetter(values, cls, info.context)
        return handler(values)

However as the function doesn't return in that case, the DjangoGetter is still instantiated and handler is run on that as well (final lines). When I modify it too

        if cls.model_config.get("extra") == "forbid":
            return handler(values)

Attribute assignment and validation work as expected. I'm not sure if that how it's supposed to work, but could be a different approach to get this easily resolved rather than the full addition of supporting __dict__ as provided in the PR by @austinpgraham .

from django-ninja.