Comments (2)
Hey @AndrewZurn I have not seen the behavior your described before, sorry. That said, you make some reasonable suggestions:
- Change
def authorize
anddef refresh
to use Json rather than form-urlencoded - Switch some of the private fields to protected to allow extension through inheritance
I'd prefer the first option, simply because once something is protected, you ideally want to keep things (mostly) backward compatible for anyone building off the Client.
Want to take a stab at changing the auth sequence to Json? Should be relatively straightforward. If not, I may get around to in the coming week.
from scala-redox.
I could probably get around to completing Option 1 early next week (I currently have it working in my own forked version for my company's project, so it should take long to replicate here).
I might take a stab at decoupling the authorization from the mechanism that stores it as to allow for some easier customization (I'll keep all of the current private members private).
Thanks!
from scala-redox.
Related Issues (20)
- New Maintainer Wanted!
- More robust Json reads HOT 2
- Support for Scala 2.12.x HOT 3
- Get coverage information during testing HOT 2
- BasicPerson in AdvanceDirective should have Credentials as Option[String] not Seq[String] HOT 2
- Clinical info empty code field
- Set up CI to perform releases HOT 1
- Add support for FlowSheet HOT 1
- Missing json-annotation dependency while cross-building to 2.12 HOT 1
- 2.12 cross-build is broken by missing specs2 dependency
- Use sensible default fallbacks for Enum values HOT 1
- Make non-critical fields more robust HOT 3
- Add property based testing
- Create robust parses for premitive types
- Robust parsing failing on multiple failures in arrays
- Build for scala version 2.11 is failing
- Failure to publish is not exiting with the correct error code HOT 1
- Build artefacts not getting published to Sonatype HOT 1
- Invalid enum value for Orders.Priority
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from scala-redox.