Code Monkey home page Code Monkey logo

Comments (2)

apatzer avatar apatzer commented on August 29, 2024

Hey @AndrewZurn I have not seen the behavior your described before, sorry. That said, you make some reasonable suggestions:

  • Change def authorize and def refresh to use Json rather than form-urlencoded
  • Switch some of the private fields to protected to allow extension through inheritance

I'd prefer the first option, simply because once something is protected, you ideally want to keep things (mostly) backward compatible for anyone building off the Client.

Want to take a stab at changing the auth sequence to Json? Should be relatively straightforward. If not, I may get around to in the coming week.

from scala-redox.

AndrewZurn avatar AndrewZurn commented on August 29, 2024

I could probably get around to completing Option 1 early next week (I currently have it working in my own forked version for my company's project, so it should take long to replicate here).

I might take a stab at decoupling the authorization from the mechanism that stores it as to allow for some easier customization (I'll keep all of the current private members private).

Thanks!

from scala-redox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.