examples/app-pyglet.py about vispy HOT 13 CLOSED

Same on Windows 8 + AMD GPU.

from vispy.

Strange, for me it works fine. (Ubuntu Linux).

The docs seem pretty clear about this.
http://www.pyglet.org/doc/api/pyglet.window.Window-class.html#on_key_press
We just do text = chr(key) in vispy/app/backends/pyglet.py

Can either of you have a look at this?

from vispy.

on_key_press is really about keycode while one_text will give you the actual letter:

http://www.pyglet.org/doc/api/pyglet.window.Window-class.html#on_text

On Aug 8, 2013, at 2:06 PM, Almar Klein [email protected] wrote:

Strange, for me it works fine. (Ubuntu Linux).

The docs seem pretty clear about this.
http://www.pyglet.org/doc/api/pyglet.window.Window-class.html#on_key_press
We just do text = chr(key) in vispy/app/backends/pyglet.py

Can either of you have a look at this?

---

Reply to this email directly or view it on GitHub:
#11 (comment)

from vispy.

Arg. Pyglet keeps being annoying. Should we try to combine the two events somehow? This requires some thought. Perhaps @lcampagn has a good idea how to handle this?

from vispy.

As I've said, I don't think it is always necessary to cover up the differences between backends. The point of having a pyglet backend is to accomodate developers who prefer to work with pyglet, not to allow backend-independent applications. So to me, the most straightforward approach is to add an on_text event to the pyglet backend.

from vispy.

But then, would not two Key events being generated for most keys being pressed?

from vispy.

Yes, but they could be made distinguishable. Or, a KeyEvent and a TextEvent might be generated. It seems that is how pyglet is designed to be used..

from vispy.

Creating a TextEvent class just for pyglet goes a bit too far IMO.

from vispy.

I think GLFW is doing the same (but is it is called key and char).

On Aug 9, 2013, at 2:35 PM, Almar Klein [email protected] wrote:

Creating a TextEvent class just for pyglet goes a bit too far IMO.

---

Reply to this email directly or view it on GitHub:
#11 (comment)

from vispy.

I think most application would do fine if we simply make on_text generate a second KeyEvent:

If e.g. an arrow key is pressed, only one event is generated (the same that would be generated now)

If e.g. the "a" is pressed, at first the on_key_press is fired, but we will set its text attribute to an empty string. Then the second event (from on_text) will have the correct text attribute. The only situation (I think) where this goes wrong if a key event handler listens for character keys using event.key: for pyglet they would trigger twice.

from vispy.

I made a change to the pyglet backend:
1184c45

Let me know if this about fixes the problem.

from vispy.

Yep, works for me.

On Aug 12, 2013, at 10:51 AM, Almar Klein [email protected] wrote:

I made a change to the pyglet backend:
1184c45

Let me know if this about fixes the problem.

---

Reply to this email directly or view it on GitHub:
#11 (comment)

from vispy.

Works for me too.

from vispy.