Comments (3)
Hello @jcchavezs, the latest v0.7.0 release of the package incorporates some of the improvements that you kindly suggested including better default for HTTP span names and configuration options for logged headers.
That being said, I'll be withholding a transition to idiomatic Zipkin tags for now. It seems like OpenTracing semantic guide doesn't have a particularly varied selection of idiomatic tags and I'd rather not mix and match between these and our own custom ones unless there is good reason for it.
One such example is an error
tag that we avail off in the latest release and helps with visually identifying spans for operations that couldn't be completed successfully. I am all for adopting names like these that have real practical benefits when working with query UI. Otherwise, I'd rather preserve consistency across all implementations that happen to already consume this package which affects us internally at Vinelab also.
I'll keep this discussion open for reference and in case we discover other uses for idiomatic tags that are worth exploring.
from tracing-laravel.
Thank you for the feedback, there is a lot of good suggestions here. I made plans to include these in future versions of the package.
from tracing-laravel.
Another use case: Idiomatic tags like span.kind
seem to be required in order to take advantage of things like Grafana Tempo's Service Graphs (https://grafana.com/docs/tempo/latest/metrics-generator/service_graphs).
from tracing-laravel.
Related Issues (15)
- Tracing db queries HOT 1
- Can't install on laravel 8 HOT 1
- How to got json detail for rootSpan after finish? HOT 2
- How to get spanMap as an array after span is finished? HOT 3
- Migrate to Zipkin 2.0 HOT 2
- 'Vinelab\Tracing\Contracts\Tracer' is not Instantiable HOT 2
- Too few arguments to function 'Illuminate\Support\Manager::createDriver()' HOT 5
- Lumen Support HOT 2
- Has anyone considered adding more events to Laravel? HOT 4
- Lumen with Vinelab/tracing-laravel plugin raised error HOT 1
- Drop support for some older versions of PHP and Laravel in the next major release HOT 7
- Why does `sampler` not support `PercentageSampler`
- 🐞 Bug - v2.3.2 - Invalid sampler class. Expected `BinarySampler` or `PercentageSampler`, got 0.000000 HOT 5
- Are we considering supporting `QueueReport`? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tracing-laravel.