Code Monkey home page Code Monkey logo

Comments (8)

f-aguzzi avatar f-aguzzi commented on August 20, 2024

Unfortunately abstract_graph is a mess, the most chaotic submodule in the library, and we know it. It will go through through some rounds of refactoring in the upcoming weeks. The first round is #494. Hopefully we'll be able fix this issue soon. Thanks for reporting this.

from scrapegraph-ai.

lrbmike avatar lrbmike commented on August 20, 2024

I think Langchain framework has also faced similar challenges, and I look forward to a better experience in the new version.

Unfortunately abstract_graph is a mess, the most chaotic submodule in the library, and we know it. It will go through through some rounds of refactoring in the upcoming weeks. The first round is #494. Hopefully we'll be able fix this issue soon. Thanks for reporting this.

from scrapegraph-ai.

f-aguzzi avatar f-aguzzi commented on August 20, 2024

A little update on the latest betas: embeddings are not needed anymore in any of the graphs. The RAGNode (the only node using embeddings) is now dead code, but we left it in the code base in case it might be needed in the future, and relocated all the embeddings initialization code inside of it, instead of leaving it the AbstractGraph.

All of this to say: the bug you reported probably won't be fixed until we find a new use for the RAGNode, but it won't bother you anymore because the embeddings will not be used by any graph in the upcoming releases of ScrapeGraphAI.

Thank for your input, thanks for using ScrapeGraph, and let us know in case you have any other problem with the library.

from scrapegraph-ai.

lrbmike avatar lrbmike commented on August 20, 2024

Great! I'll have a try.

from scrapegraph-ai.

lrbmike avatar lrbmike commented on August 20, 2024

@f-aguzzi In the latest version v1.12.2, I still found some mistakes with gemini model.

In abstract_graph.py file, use "google_genai".

        if "gemini" in llm_params["model"]:
            model_name = llm_params["model"].split("/")[-1]
            return handle_model(model_name, "google_genai", model_name)

But in models_tokens.py file, still use "gemini" .

from scrapegraph-ai.

f-aguzzi avatar f-aguzzi commented on August 20, 2024

@f-aguzzi In the latest version v1.12.2, I still found some mistakes with gemini model.

In abstract_graph.py file, use "google_genai".

        if "gemini" in llm_params["model"]:
            model_name = llm_params["model"].split("/")[-1]
            return handle_model(model_name, "google_genai", model_name)

But in models_tokens.py file, still use "gemini" .

We'll fix this ASAP, thanks for reporting it to us

from scrapegraph-ai.

github-actions avatar github-actions commented on August 20, 2024

๐ŸŽ‰ This issue has been resolved in version 1.14.0-beta.3 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€

from scrapegraph-ai.

VinciGit00 avatar VinciGit00 commented on August 20, 2024

hi please update to the new beta

from scrapegraph-ai.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.