vincent3569 / zpbootstrap Goto Github PK

Some name changes have been made in ZenPhoto 1.6 which are not allowed for in deprecated functions.
The minimum changes required are
diff inc_footer.php ../../zpBootstrapFor1.6/inc_footer.php
5c5
< echo getMainSiteName();

                          echo getParentSiteTitle();

diff inc_header.php ../../zpBootstrapFor1.6/inc_header.php
19c19
< echo getMainSiteName() . ' | ';

  echo getParentSiteTitle() . ' | ';

195c195
<

Hi,
It would be interesting to add in the zpbootstrap menu or filter: the highest rated, most recent, most viewed, most popular images.
Users can see that they are the best images of the sites, the latest images published, and the most popular.

Thank You

The headline semantics are not correct on the theme. It seems you only use h3 headlines which is invalid if there is no h2 or h1 headline. This is also important for SEO.

Generally every page should have one h1 headline. Only on the home page the h1 should be the site/gallery title for SEO. On every other page it should be the page title (e.g. image title, album title, Zenpage page, category or article etc).

All other headlines can be used multiple times abut must follow the proper nesting.

(And yes, the current old official Zenphoto themes don't do everything fully correct either but future ones will.)

Bootswatch is open source and free it offers several templates so since the administration of zenphoto can choose the template to use which makes it very customizable.
https://bootswatch.com/

I open this issue because included translations need to be updated (german, dutch, italian and spanish).
Of course, other translations may be submited.

If you are a translator, fork my repository and edit .po files with poedit.
Then make a pull request to send me your translation (.po and .mo files).

Thanks!

There is code in the zpBootstrap themeoptions constructor line 42-46 that disables colrobox_js, slideshow, and slideshow2. While it may well be that zpBootstrap does not want these plugins disabled other themes may not feel the same. This code gets run each time that setup runs and whenever one views the zpBootstrap options on the admin pages. Thus, these actions will disable those plugins even if zpBootstrap is not the active theme. This is insidious since the site administrator will likely not even notice the change. His site will simply not work as he intended.

I am not clear as to why zpBootstrap needs these plugins disabled. But there should be a more site friendly disabling if that is needed. For instance the them functions.php script can disable them temporarily by calling enableExtension() with the optional third parameter set to false to make the change not persistent. Another option would be to set the scripts not to load via setOption('colorbox_zpBootstrap_scripts', serialize(array())); in the themeoptions constructor.

Thanks for the amazing theme, its really just what I was looking for.

I have a site https://alldemophotos.cookingisfun.ie/2017/ which I have uploaded your theme to. It works great, but on some albums when I activate fancybox the urls are incorrect so the images dont load.

This album works fine.

https://alldemophotos.cookingisfun.ie/2017/A%20Week%20at%20Ballymaloe%20Cookery%20School%2C%20Organic%20Farm%20%20Gardens/Mon%203rd%20Apr%202017/

However most other albums display a {{ERROR}}

eg https://alldemophotos.cookingisfun.ie/2017/A%20Week%20at%20Ballymaloe%20Cookery%20School%2C%20Organic%20Farm%20%20Gardens/Tue%204th%20Apr%202017/

The issue seems to be that it is for some reason linking to the images using the full disk path eg

https://alldemophotos.cookingisfun.ie/home/cookingisfunweb/alldemophotos.cookingisfun.ie/allimages/Gallery/2017/A%20Week%20at%20Ballymaloe%20Cookery%20School%2C%20Organic%20Farm%20%20Gardens/Tue%204th%20Apr%202017/2017-04-04%2016.28.41.jpg

this is invalid due to the part at the front of the url

/home/cookingisfunweb/alldemophotos.cookingisfun.ie/allimages/Gallery/

I am happy to try to fix the issue if you point me in the right direction.

Thanks again.

When clicking Activate it does nothing and goes to default theme.

Never mind I finally figured it out. The version numbers behind the zpBootstrap folder have to be deleted. Once I renamed the file to zpBootstrap it is working.

Running zpBootstrap 2.0 under PHP 7 gives the following warning:

EXCEPTION (8192): "Methods with the same name as their class will not be constructors in a future version of PHP; ThemeOptions has a deprecated constructor" in D:\test_sites\dev\themes\zpBootstrap-2.0\themeoptions.php on line 12

function ThemeOptions() { should instead be function __construct() {