Comments (10)
Hey this would be a great addition. Any idea if this can be included @vinceglb ?
from filekit.
Take a look at PR #60. There are quite a few limitations to this feature. I will keep working on it and try to cover as much area as possible, but I'm not sure how useful it is if it works on few platforms and fewer usecases.
from filekit.
@santiwanti Maybe take a look at https://github.com/onseok/peekaboo for reference?
This already has the functionality but is not actively maintained.
from filekit.
@LaatonWalaBhoot I will take a look at this for the iOS side. But still, keep in mind that FileKit supports more platforms than just iOS / Android and more files than just media
from filekit.
Thanks @santiwanti
However I wonder. Such a functionality would be useful for all platforms right?
Use case being e-commerce or social media apps
from filekit.
I do think it would be helpful, the problem is that maintaining it for some platforms will be harder than for others because we have to do it manually instead of letting the systems libraries handle it for us.
The only platforms I have seen that have library support for maxSelection
are Android and iOS and only when it comes to images
from filekit.
Agreed. I guess we can keep this open once mobile platforms are supported. I can try putting in a PR for other platforms
from filekit.
@LaatonWalaBhoot the PR for mobile platforms is done. If it's decided that it will be merged I will probably have to clean it up a bit, but the functionality is there.
Regarding implementing the feature for other platforms, I would advise to wait until @vinceglb confirms that that is something he wants. Implementing the feature is the first step, it then has to be maintained and removing features is harder than adding them.
from filekit.
Sure thanks @santiwanti
from filekit.
@vinceglb There is a draft PR for this available. Any ideas if it will be reviewed and merged?
from filekit.
Related Issues (19)
- dosent support minsdk lower than 24 HOT 4
- [win] Support modal dialogs (hwndOwner) HOT 3
- [win] Bug: File extension filters persist across invocations HOT 1
- Android: AutoInitialize libray? HOT 4
- Not localized on macOS (JVM) HOT 2
- Option to use the better file picker on Windows HOT 3
- Encountered an issue while using the Save File Picker HOT 3
- Js target is missing for filekit-compose HOT 5
- Unable to locate JNA native support library HOT 5
- ReadBytes() crashes on iOS sometimes HOT 5
- Android Preview does not function HOT 2
- Please provide file-stream HOT 1
- Ios video picker error HOT 2
- Problems when creating Release Distributable for Desktop with Proguard HOT 7
- readByte() crashes when running application on a real device HOT 5
- Add Xdg Desktop File Chooser Portal for Linux
- IOS
- Feature to pick and store files from a specific path without File Picker
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from filekit.