IPaymentClient should inherit from IDisposable about mollieapi HOT 7 CLOSED

This is now done and will be released in the next version

from mollieapi.

Looks great Vincent!

from mollieapi.

This is now live in 3.1.0.0
https://github.com/Viincenttt/MollieApi/releases/tag/3.1.0.0

from mollieapi.

Just a nitpicky comment about the wording of "one will be created and disposed for you." in the home page tutorial. The caller has to explicitly call Dispose() himself (through the use of "using"), so it's not being magically being disposed without the caller calling Dispose().

A completely unrelated comment (about the documentation): it would be useful to demonstrate the use of PaymentResponse.Links.Checkout.Href in the "Payment API" paragraph. I think most users will use the Mollie payment pages and will have to redirect to this url. It's no big deal, because I found it in 10 minutes in the mollie docs, but if this would have been included in the howto, it would have been already usable right out of the box to do a complete payment.

from mollieapi.

Thanks for the feedback @woutware , I really appreciate it! :)

I'll update the documentation to make this part a bit more clear

from mollieapi.

Hi @woutware ,

Good idea, I agree with your suggestion. The recommended way to use the Mollie .NET client is to use the recently introduced dependency injection extension method, as described in the documentation:
https://github.com/Viincenttt/MollieApi#dependency-injection

In case someone is not using dependency injection and is using the constructor variant where no HttpClient instance is provided, I'll see if I can add some code to dispose the HttpClient instance that is created by the Mollie API classes.

Kind regards,
Vincent

from mollieapi.

The wording is much better now! And the checkout url paragraph looks good too, overall great job on the documentation!

from mollieapi.